Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Side by Side Diff: Source/core/svg/SVGAElement.cpp

Issue 896383002: Revert 184783 "The link should be activated by enter key on focus.." (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/html/HTMLAnchorElement.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2008 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2008 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2007 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2007 Rob Buis <buis@kde.org>
4 * Copyright (C) 2007 Eric Seidel <eric@webkit.org> 4 * Copyright (C) 2007 Eric Seidel <eric@webkit.org>
5 * Copyright (C) 2010 Apple Inc. All rights reserved. 5 * Copyright (C) 2010 Apple Inc. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 100 matching lines...) Expand 10 before | Expand all | Expand 10 after
111 { 111 {
112 if (parentNode() && parentNode()->isSVGElement() && toSVGElement(parentNode( ))->isTextContent()) 112 if (parentNode() && parentNode()->isSVGElement() && toSVGElement(parentNode( ))->isTextContent())
113 return new RenderSVGInline(this); 113 return new RenderSVGInline(this);
114 114
115 return new RenderSVGTransformableContainer(this); 115 return new RenderSVGTransformableContainer(this);
116 } 116 }
117 117
118 void SVGAElement::defaultEventHandler(Event* event) 118 void SVGAElement::defaultEventHandler(Event* event)
119 { 119 {
120 if (isLink()) { 120 if (isLink()) {
121 Node* target = event->target() ? event->target()->toNode() : 0; 121 if (focused() && isEnterKeyKeydownEvent(event)) {
122 bool hasFocus = focused() || (target && target->focused());
123 if (hasFocus && isEnterKeyKeypressEvent(event)) {
124 event->setDefaultHandled(); 122 event->setDefaultHandled();
125 dispatchSimulatedClick(event); 123 dispatchSimulatedClick(event);
126 return; 124 return;
127 } 125 }
128 126
129 if (isLinkClick(event)) { 127 if (isLinkClick(event)) {
130 String url = stripLeadingAndTrailingHTMLSpaces(hrefString()); 128 String url = stripLeadingAndTrailingHTMLSpaces(hrefString());
131 129
132 if (url[0] == '#') { 130 if (url[0] == '#') {
133 Element* targetElement = treeScope().getElementById(AtomicString (url.substring(1))); 131 Element* targetElement = treeScope().getElementById(AtomicString (url.substring(1)));
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
211 return SVGElement::canStartSelection(); 209 return SVGElement::canStartSelection();
212 return hasEditableStyle(); 210 return hasEditableStyle();
213 } 211 }
214 212
215 bool SVGAElement::willRespondToMouseClickEvents() 213 bool SVGAElement::willRespondToMouseClickEvents()
216 { 214 {
217 return isLink() || SVGGraphicsElement::willRespondToMouseClickEvents(); 215 return isLink() || SVGGraphicsElement::willRespondToMouseClickEvents();
218 } 216 }
219 217
220 } // namespace blink 218 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/html/HTMLAnchorElement.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698