Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1532)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 896163003: Revert "Move DstCopy on gpu into the GrXferProcessor." (Closed)

Created:
5 years, 10 months ago by egdaniel
Modified:
5 years, 10 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert "Move DstCopy on gpu into the GrXferProcessor." This reverts commit 74a11753604768bf461b80cabb66060e8564d82c. TBR=joshualitt@google.com,bsalomon@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/3e9dfdb3784c0cbfecf7589a74aa9aff7ef40abd Committed: https://skia.googlesource.com/skia/+/4dce32c46675efb901618161771d450241af4307

Patch Set 1 #

Patch Set 2 : Fix revert #

Unified diffs Side-by-side diffs Delta from patch set Stats (+374 lines, -403 lines) Patch
M gyp/gpu.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
M include/gpu/GrXferProcessor.h View 7 chunks +19 lines, -53 lines 0 comments Download
M include/gpu/effects/GrPorterDuffXferProcessor.h View 4 chunks +10 lines, -15 lines 0 comments Download
M src/effects/SkArithmeticMode_gpu.h View 5 chunks +12 lines, -19 lines 0 comments Download
M src/effects/SkArithmeticMode_gpu.cpp View 3 chunks +15 lines, -16 lines 0 comments Download
M src/gpu/GrBatchTarget.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/GrBatchTarget.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 4 chunks +6 lines, -5 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 9 chunks +44 lines, -13 lines 0 comments Download
M src/gpu/GrGpu.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.h View 4 chunks +7 lines, -6 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.cpp View 7 chunks +14 lines, -20 lines 0 comments Download
M src/gpu/GrPipeline.h View 2 chunks +5 lines, -2 lines 0 comments Download
M src/gpu/GrPipeline.cpp View 5 chunks +12 lines, -5 lines 0 comments Download
M src/gpu/GrPipelineBuilder.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/gpu/GrPipelineBuilder.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrProgramDesc.h View 2 chunks +17 lines, -0 lines 0 comments Download
M src/gpu/GrTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
D src/gpu/GrXferProcessor.cpp View 1 chunk +0 lines, -55 lines 0 comments Download
M src/gpu/effects/GrCoverageSetOpXP.h View 4 chunks +7 lines, -8 lines 0 comments Download
M src/gpu/effects/GrCoverageSetOpXP.cpp View 4 chunks +13 lines, -15 lines 0 comments Download
M src/gpu/effects/GrCustomXfermode.cpp View 2 chunks +14 lines, -14 lines 0 comments Download
M src/gpu/effects/GrCustomXfermodePriv.h View 6 chunks +12 lines, -15 lines 0 comments Download
M src/gpu/effects/GrDisableColorXP.h View 4 chunks +7 lines, -8 lines 0 comments Download
M src/gpu/effects/GrDisableColorXP.cpp View 4 chunks +8 lines, -10 lines 0 comments Download
M src/gpu/effects/GrPorterDuffXferProcessor.cpp View 5 chunks +18 lines, -29 lines 0 comments Download
M src/gpu/gl/GrGLGpu.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 2 chunks +31 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLProgramDesc.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLProgramDesc.cpp View 2 chunks +16 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLXferProcessor.h View 2 chunks +4 lines, -14 lines 0 comments Download
D src/gpu/gl/GrGLXferProcessor.cpp View 1 chunk +0 lines, -61 lines 0 comments Download
M src/gpu/gl/builders/GrGLFragmentShaderBuilder.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/gl/builders/GrGLFragmentShaderBuilder.cpp View 1 chunk +49 lines, -2 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M tests/GLProgramsTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/896163003/1
5 years, 10 months ago (2015-02-04 14:14:03 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/3e9dfdb3784c0cbfecf7589a74aa9aff7ef40abd
5 years, 10 months ago (2015-02-04 14:14:27 UTC) #3
egdaniel
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/900913002/ by egdaniel@google.com. ...
5 years, 10 months ago (2015-02-04 14:19:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/896163003/20001
5 years, 10 months ago (2015-02-04 14:25:04 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 14:25:33 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/4dce32c46675efb901618161771d450241af4307

Powered by Google App Engine
This is Rietveld 408576698