Revert of Issue FrameDestructionObserver::frameDestroyed() notification on detach.

Revert of Issue FrameDestructionObserver::frameDestroyed() notification on detach. (patchset #2 id:20001 of https://codereview.chromium.org/881683003/)

Reason for revert:
ScreenOrientationBrowserTest.CrashTest_UseAfterDetach failing on ChromeOS b/w
blink 189439 - 189443, suspect 189443, revert to see if ChromeOS greens.


Original issue's description:
> Issue FrameDestructionObserver::frameDestroyed() notification on detach.
> 
> Send this notification during detach instead of waiting until finalization,
> which will typically proceed shortly afterwards (non-Oilpan.)
> 
> Doing so provides identical lifetimes for FrameDestructionObserver's
> frame reference, with and without Oilpan. Making GC/finalization of frames
> not be externally observable is preferable overall.
> 
> R=haraken,dcheng
> BUG=446452
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189443

TBR=dcheng@chromium.org,haraken@chromium.org,oilpan-reviews@chromium.org,sigbjornf@opera.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=446452
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189454

[Noel Gordon, 2015-02-04 05:23:41]

Created Revert of Issue FrameDestructionObserver::frameDestroyed() notification
on detach.

[Noel Gordon, 2015-02-04 05:24:11]

noel@chromium.org changed reviewers:
+ japhet@chromium.org

[commit-bot: I haz the power, 2015-02-04 05:24:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/896103002/1

[commit-bot: I haz the power, 2015-02-04 05:25:23]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189454

[haraken, 2015-02-04 05:50:37]

LGTM

[Noel Gordon, 2015-02-04 06:01:14]

http://build.chromium.org/p/chromium.webkit/builders/Linux%20ChromiumOS%20Tes...

ChromeOS Bot did not cycle green. Reverting this revert.

[Noel Gordon, 2015-02-04 06:05:09]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/890243003/ by noel@chromium.org.

The reason for reverting is: ChromeOS bot did not cycle green at Blink r189454,
so will re-land Blink r189443..

[sof, 2015-02-04 06:12:47]

On 2015/02/04 06:05:09, noel gordon wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/890243003/ by mailto:noel@chromium.org.
> 
> The reason for reverting is: ChromeOS bot did not cycle green at Blink
r189454,
> so will re-land Blink r189443..

Thanks for all the work here, do you have a link to the failing test?

Judging by the test's name, I'm not convinced there's zero overlap with this CL.
Not in a crashing sense, but it will detach .screen from view slightly earlier.

[Noel Gordon, 2015-02-04 06:18:53]

On 2015/02/04 06:12:47, sof wrote:
> On 2015/02/04 06:05:09, noel gordon wrote:
> > A revert of this CL (patchset #1 id:1) has been created in
> > https://codereview.chromium.org/890243003/ by mailto:noel@chromium.org.
> > 
> > The reason for reverting is: ChromeOS bot did not cycle green at Blink
> r189454,
> > so will re-land Blink r189443..
> 
> Thanks for all the work here, do you have a link to the failing test?

See
http://build.chromium.org/p/chromium.webkit/builders/Linux%20ChromiumOS%20Tes...

ScreenOrientationBrowserTest.CrashTest_UseAfterDetach

> Judging by the test's name, I'm not convinced there's zero overlap with this
CL.

Had that idea (some overlap) myself.

> Not in a crashing sense, but it will detach .screen from view slightly
earlier.

Yes, test uses screen orientation after some kind of _detach_ and not crash. 
Seems it now does crash.

[Noel Gordon, 2015-02-04 06:22:38]

Seems that test is dying in a js callback.  Hmmm callbacks are ActiveDOMObjects
and should (or do normally) handle callback invocation after (at least) a
Document detach.  Not sure about FrameDestruction.

[Noel Gordon, 2015-02-04 06:23:42]

On 2015/02/04 06:22:38, noel gordon wrote:
> Seems that test is dying in a js callback.  Hmmm callbacks are
ActiveDOMObjects
> and should (or do normally) handle callback invocation after (at least) a
> Document detach.  Not sure about FrameDestruction.

Hmmm in stack trace:  ASSERTION FAILED: frame()

[Noel Gordon, 2015-02-04 06:35:03]

And jsut for spice: the lastest
http://build.chromium.org/p/chromium.webkit/builders/Linux%20ChromiumOS%20Tes...
build went green!!!

[Noel Gordon, 2015-02-04 06:53:56]

noel@chromium.org changed reviewers:
+ mlamouri@chromium.org

[Noel Gordon, 2015-02-04 06:54:21]

+ mlamouri who might educate us.

[Noel Gordon, 2015-02-04 07:12:36]

https://codereview.chromium.org/902503002 the
ScreenOrientationBrowserTest.CrashTest_UseAfterDetach failure is preventing the
webkit roll.