Source/modules/serviceworkers/ServiceWorkerGlobalScope.h - Issue 896043004: Tests for WaitUntilObserver and focus/openining windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/ServiceWorkerGlobalScope.h

Issue 896043004: Tests for WaitUntilObserver and focus/openining windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@sw_client_focus_cleanup

Patch Set: review comments Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/http/tests/serviceworker/notificationclick-can-focus.html ('K') | « LayoutTests/http/tests/serviceworker/resources/notificationclick-can-openwindow.js ('k') | Source/modules/serviceworkers/WaitUntilObserver.h » ('j') | Source/modules/serviceworkers/testing/InternalsServiceWorker.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/serviceworkers/ServiceWorkerGlobalScope.h

diff --git a/Source/modules/serviceworkers/ServiceWorkerGlobalScope.h b/Source/modules/serviceworkers/ServiceWorkerGlobalScope.h

index 48e8cccfaaec78a68a686944b3e3ed04e0599e2d..a637c7fb0c4771d4d4fe5026248d715201280b26 100644

--- a/Source/modules/serviceworkers/ServiceWorkerGlobalScope.h

+++ b/Source/modules/serviceworkers/ServiceWorkerGlobalScope.h

@@ -95,7 +95,8 @@ public:

// Timeout before a service worker that was given window interaction

// permission loses them. The unit is seconds.

- static const int kWindowInteractionTimeout = 10;

+ static const unsigned kWindowInteractionTimeout = 10;

dominicc (has gone to gerrit) 2015/02/09 07:03:09 These could move into the implementation file sinc

mlamouri (slow - plz ping) 2015/02/11 10:42:06 I wanted to have it there for future use but yeah,

+ static const unsigned kWindowInteractionTimeoutForTest = 1;

private:

class SkipWaitingCallback;