Source/modules/serviceworkers/WaitUntilObserver.h - Issue 896043004: Tests for WaitUntilObserver and focus/openining windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/WaitUntilObserver.h

Issue 896043004: Tests for WaitUntilObserver and focus/openining windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@sw_client_focus_cleanup

Patch Set: review comments Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/serviceworkers/ServiceWorkerGlobalScope.h ('K') | « Source/modules/serviceworkers/ServiceWorkerGlobalScope.h ('k') | Source/modules/serviceworkers/WaitUntilObserver.cpp » ('j') | Source/modules/serviceworkers/testing/InternalsServiceWorker.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/serviceworkers/WaitUntilObserver.h

diff --git a/Source/modules/serviceworkers/WaitUntilObserver.h b/Source/modules/serviceworkers/WaitUntilObserver.h

index b95e68f69599b9ca9dcf54406afacc03a584bd3c..d37e3b2bb76080f8f6d5b22bbef4506292562cb1 100644

--- a/Source/modules/serviceworkers/WaitUntilObserver.h

+++ b/Source/modules/serviceworkers/WaitUntilObserver.h

@@ -42,6 +42,7 @@ public:

virtual void trace(Visitor*) override;

private:

+ friend class InternalsServiceWorker;

class ThenFunction;

WaitUntilObserver(ExecutionContext*, EventType, int eventID);