Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Unified Diff: chromeos/accelerometer/accelerometer_reader.cc

Issue 895993002: Correcly Report CanEnterMaximizeMode on devices without accelerometers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/wm/maximize_mode/maximize_mode_controller_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/accelerometer/accelerometer_reader.cc
diff --git a/chromeos/accelerometer/accelerometer_reader.cc b/chromeos/accelerometer/accelerometer_reader.cc
index 4d68ebf0957ec5c811208b2430604a27e489a0da..92f1448e60bbe40a154b1506f5ddeb448d8d3a52 100644
--- a/chromeos/accelerometer/accelerometer_reader.cc
+++ b/chromeos/accelerometer/accelerometer_reader.cc
@@ -203,7 +203,10 @@ void AccelerometerReader::Initialize(
void AccelerometerReader::AddObserver(Observer* observer) {
observers_.AddObserver(observer);
- observer->OnAccelerometerUpdated(update_);
+ if (update_.has(chromeos::ACCELEROMETER_SOURCE_ATTACHED_KEYBOARD) ||
+ update_.has(chromeos::ACCELEROMETER_SOURCE_SCREEN)) {
flackr 2015/02/04 18:44:52 I'd prefer adding a bool for if it has gotten a re
jonross 2015/02/04 19:00:59 Done.
+ observer->OnAccelerometerUpdated(update_);
+ }
}
void AccelerometerReader::RemoveObserver(Observer* observer) {
« no previous file with comments | « ash/wm/maximize_mode/maximize_mode_controller_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698