Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Unified Diff: ash/wm/maximize_mode/maximize_mode_controller_unittest.cc

Issue 895993002: Correcly Report CanEnterMaximizeMode on devices without accelerometers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/wm/maximize_mode/maximize_mode_controller_unittest.cc
diff --git a/ash/wm/maximize_mode/maximize_mode_controller_unittest.cc b/ash/wm/maximize_mode/maximize_mode_controller_unittest.cc
index b3f043434e3c1fee1a73a3406e6b62d95d30cc3a..7ac5fa187d9674b525b7bdbea5319d7a730b2574 100644
--- a/ash/wm/maximize_mode/maximize_mode_controller_unittest.cc
+++ b/ash/wm/maximize_mode/maximize_mode_controller_unittest.cc
@@ -346,6 +346,26 @@ TEST_F(MaximizeModeControllerTest, MaximizeModeTest) {
}
}
+// Tests that when and empty accelerometer update is received for attaching as a
+// chromeos::AccelerometerReader::Observer, that CanEnterMaximizeMode returns
+// false, and that valid accelerometer events allow entering maximize mode.
+TEST_F(MaximizeModeControllerTest,
+ CanEnterMaximizeModeRequiresValidAccelerometerUpdate) {
+ // Should be false until an accelerometer event is sent.
+ ASSERT_FALSE(maximize_mode_controller()->CanEnterMaximizeMode());
+ OpenLidToAngle(90.0f);
+ EXPECT_TRUE(maximize_mode_controller()->CanEnterMaximizeMode());
+}
+
+// Tests that when an accelerometer event is received which has no keyboard that
+// we enter maximize mode.
+TEST_F(MaximizeModeControllerTest,
+ NoKeyboardAccelerometerTriggersMaximizeMode) {
+ ASSERT_FALSE(IsMaximizeModeStarted());
+ TriggerLidUpdate(gfx::Vector3dF(0.0f, 0.0f, kMeanGravity));
+ ASSERT_TRUE(IsMaximizeModeStarted());
+}
+
class MaximizeModeControllerSwitchesTest : public MaximizeModeControllerTest {
public:
MaximizeModeControllerSwitchesTest() {}
« no previous file with comments | « no previous file | chromeos/accelerometer/accelerometer_reader.cc » ('j') | chromeos/accelerometer/accelerometer_reader.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698