Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 895933004: Add UniformBlocks related commands to command buffer. (Closed)

Created:
5 years, 10 months ago by Zhenyao Mo
Modified:
5 years, 10 months ago
Reviewers:
piman
CC:
chromium-reviews, Ken Russell (switch to Gerrit), bajones, no sievers, vmiura
Base URL:
https://chromium.googlesource.com/chromium/src.git@uniform
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add UniformBlock related commands to command buffer. 1) glGetUniformBlocksCHROMIUM This is Chromium GPU command buffer internal command. The purpose is to fetch UniformBlock related information in a linked program from service side in one command instead of multiple ones. 2) glGetUniformBlockIndex 3) glGetActiveUniformBlockName Get value from client side cache (retrieved by GetUniformBlockCHROMIUM); if that fails, send the command to service side. What's missing: glGetActiveUniformBlockiv. It requires some extra tuning, so leave that for a separate CL. BUG=453127, 429053 TEST=gpu_unittests R=piman@chromium.org Committed: https://crrev.com/4a16ff998e64bf2aa245339035acdf9a05819c9d Cr-Commit-Position: refs/heads/master@{#314897}

Patch Set 1 : glGetUniformBlocksCHROMIUM #

Patch Set 2 : glGetUniformBlockIndex #

Patch Set 3 : glGetActiveUniformBlockName #

Patch Set 4 : Fix #

Patch Set 5 : Working #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1309 lines, -286 lines) Patch
M gpu/GLES2/gl2chromium_autogen.h View 1 2 3 chunks +3 lines, -0 lines 0 comments Download
M gpu/command_buffer/build_gles2_cmd_buffer.py View 1 2 3 2 chunks +30 lines, -1 line 0 comments Download
M gpu/command_buffer/client/gles2_c_lib_autogen.h View 1 2 6 chunks +29 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_cmd_helper_autogen.h View 1 2 3 chunks +31 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.h View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.cc View 1 2 3 3 chunks +133 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_autogen.h View 1 2 3 chunks +13 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_unittest.cc View 1 2 3 1 chunk +102 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_unittest_autogen.h View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_autogen.h View 1 2 3 chunks +10 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_stub_autogen.h View 1 2 3 chunks +10 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_stub_impl_autogen.h View 1 2 3 chunks +15 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_trace_implementation_autogen.h View 1 2 3 chunks +10 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_trace_implementation_impl_autogen.h View 1 2 3 chunks +23 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/program_info_manager.cc View 1 2 3 chunks +24 lines, -13 lines 0 comments Download
M gpu/command_buffer/client/program_info_manager_unittest.cc View 1 2 3 4 chunks +119 lines, -46 lines 0 comments Download
M gpu/command_buffer/cmd_buffer_functions.txt View 1 2 3 chunks +3 lines, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_autogen.h View 1 2 3 chunks +157 lines, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_test_autogen.h View 1 2 3 chunks +46 lines, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_ids_autogen.h View 1 2 1 chunk +192 lines, -189 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 2 3 4 4 chunks +111 lines, -6 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_1_autogen.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_2_autogen.h View 1 2 2 chunks +4 lines, -29 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_3_autogen.h View 1 2 2 chunks +31 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_programs.cc View 1 2 3 3 chunks +203 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Zhenyao Mo
piman: please review. Others: FYI (feel free to review.)
5 years, 10 months ago (2015-02-05 19:28:35 UTC) #11
piman
lgtm
5 years, 10 months ago (2015-02-05 21:51:59 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/895933004/280001
5 years, 10 months ago (2015-02-05 22:13:57 UTC) #14
commit-bot: I haz the power
Committed patchset #5 (id:280001)
5 years, 10 months ago (2015-02-05 22:19:13 UTC) #15
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 22:20:07 UTC) #16
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/4a16ff998e64bf2aa245339035acdf9a05819c9d
Cr-Commit-Position: refs/heads/master@{#314897}

Powered by Google App Engine
This is Rietveld 408576698