Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 895893002: dart2js: refactor nsm_emitter. (Closed)

Created:
5 years, 10 months ago by zarah
Modified:
5 years, 10 months ago
Reviewers:
floitsch, herhut
CC:
reviews_dartlang.org, asgerf
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: refactor nsm_emitter. This is done as a step towards sharing the handling of noSuchMethod between the new and the old emitter. R=herhut@google.com Committed: https://code.google.com/p/dart/source/detail?r=43388

Patch Set 1 #

Patch Set 2 : fixed indentation #

Patch Set 3 : Removed unused parameter. #

Total comments: 4

Patch Set 4 : Addressed comments. #

Total comments: 4

Patch Set 5 : Addressed comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -46 lines) Patch
M pkg/compiler/lib/src/js_backend/namer.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart View 1 2 3 4 6 chunks +51 lines, -46 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
zarah
5 years, 10 months ago (2015-02-03 09:00:03 UTC) #2
herhut
lgtm w/ comments https://codereview.chromium.org/895893002/diff/40001/pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart File pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart (right): https://codereview.chromium.org/895893002/diff/40001/pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart#newcode30 pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart:30: ClassElement objectClass = compiler.objectClass; How about ...
5 years, 10 months ago (2015-02-03 09:39:53 UTC) #3
zarah
https://codereview.chromium.org/895893002/diff/40001/pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart File pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart (right): https://codereview.chromium.org/895893002/diff/40001/pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart#newcode30 pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart:30: ClassElement objectClass = compiler.objectClass; On 2015/02/03 09:39:53, herhut wrote: ...
5 years, 10 months ago (2015-02-03 10:07:20 UTC) #4
floitsch
DBC. https://codereview.chromium.org/895893002/diff/60001/pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart File pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart (right): https://codereview.chromium.org/895893002/diff/60001/pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart#newcode94 pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart:94: computeSelectorsForNsmHandlers(addedJsNames); Let the computeSelectors return the map. https://codereview.chromium.org/895893002/diff/60001/pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart#newcode288 ...
5 years, 10 months ago (2015-02-03 10:56:02 UTC) #5
zarah
https://codereview.chromium.org/895893002/diff/60001/pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart File pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart (right): https://codereview.chromium.org/895893002/diff/60001/pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart#newcode94 pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart:94: computeSelectorsForNsmHandlers(addedJsNames); On 2015/02/03 10:56:02, floitsch wrote: > Let the ...
5 years, 10 months ago (2015-02-03 11:06:50 UTC) #6
zarah
Committed patchset #5 (id:80001) manually as 43388 (presubmit successful).
5 years, 10 months ago (2015-02-03 11:12:25 UTC) #7
floitsch
5 years, 10 months ago (2015-02-03 23:21:52 UTC) #8
Message was sent while issue was closed. 
ccing Asger since he is working on the namer.

Powered by Google App Engine
This is Rietveld 408576698