Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Unified Diff: cc/resources/resource_provider.cc

Issue 895853003: Update from https://crrev.com/314320 (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/resources/resource_provider.h ('k') | cc/resources/tile_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/resources/resource_provider.cc
diff --git a/cc/resources/resource_provider.cc b/cc/resources/resource_provider.cc
index 4ba46b7230d3f8608dac446b4de408a6365976f3..b90b59477376960656266cdb0f60b87d0d8173b0 100644
--- a/cc/resources/resource_provider.cc
+++ b/cc/resources/resource_provider.cc
@@ -1087,41 +1087,31 @@ ResourceProvider::ScopedWriteLockGpuMemoryBuffer::GetGpuMemoryBuffer() {
ResourceProvider::ScopedWriteLockGr::ScopedWriteLockGr(
ResourceProvider* resource_provider,
- ResourceProvider::ResourceId resource_id)
+ ResourceProvider::ResourceId resource_id,
+ bool use_distance_field_text,
+ bool can_use_lcd_text,
+ int msaa_sample_count)
: resource_provider_(resource_provider),
resource_(resource_provider->LockForWrite(resource_id)) {
-}
-
-ResourceProvider::ScopedWriteLockGr::~ScopedWriteLockGr() {
- DCHECK(thread_checker_.CalledOnValidThread());
- resource_provider_->UnlockForWrite(resource_);
-}
-
-SkSurface* ResourceProvider::ScopedWriteLockGr::GetSkSurface(
- bool use_distance_field_text,
- bool can_use_lcd_text) {
+ // Create the sk_surface.
DCHECK(thread_checker_.CalledOnValidThread());
DCHECK(resource_->locked_for_write);
- bool create_surface =
- !resource_->sk_surface.get() ||
- !SurfaceHasMatchingProperties(use_distance_field_text, can_use_lcd_text);
- if (create_surface) {
- resource_provider_->LazyAllocate(resource_);
-
- GrBackendTextureDesc desc;
- desc.fFlags = kRenderTarget_GrBackendTextureFlag;
- desc.fWidth = resource_->size.width();
- desc.fHeight = resource_->size.height();
- desc.fConfig = ToGrPixelConfig(resource_->format);
- desc.fOrigin = kTopLeft_GrSurfaceOrigin;
- desc.fTextureHandle = resource_->gl_id;
-
- class GrContext* gr_context = resource_provider_->GrContext();
- skia::RefPtr<GrTexture> gr_texture =
- skia::AdoptRef(gr_context->wrapBackendTexture(desc));
- if (!gr_texture)
- return nullptr;
+ resource_provider_->LazyAllocate(resource_);
+
+ GrBackendTextureDesc desc;
+ desc.fFlags = kRenderTarget_GrBackendTextureFlag;
+ desc.fWidth = resource_->size.width();
+ desc.fHeight = resource_->size.height();
+ desc.fConfig = ToGrPixelConfig(resource_->format);
+ desc.fOrigin = kTopLeft_GrSurfaceOrigin;
+ desc.fTextureHandle = resource_->gl_id;
+ desc.fSampleCnt = msaa_sample_count;
+
+ class GrContext* gr_context = resource_provider_->GrContext();
+ skia::RefPtr<GrTexture> gr_texture =
+ skia::AdoptRef(gr_context->wrapBackendTexture(desc));
+ if (gr_texture) {
uint32_t flags = use_distance_field_text
? SkSurfaceProps::kUseDistanceFieldFonts_Flag
: 0;
@@ -1132,22 +1122,14 @@ SkSurface* ResourceProvider::ScopedWriteLockGr::GetSkSurface(
surface_props =
SkSurfaceProps(flags, SkSurfaceProps::kLegacyFontHost_InitType);
}
- resource_->sk_surface = skia::AdoptRef(SkSurface::NewRenderTargetDirect(
+ sk_surface_ = skia::AdoptRef(SkSurface::NewRenderTargetDirect(
gr_texture->asRenderTarget(), &surface_props));
}
- return resource_->sk_surface.get();
}
-bool ResourceProvider::ScopedWriteLockGr::SurfaceHasMatchingProperties(
- bool use_distance_field_text,
- bool can_use_lcd_text) const {
- const SkSurface* surface = resource_->sk_surface.get();
- bool surface_uses_distance_field_text =
- surface->props().isUseDistanceFieldFonts();
- bool surface_can_use_lcd_text =
- surface->props().pixelGeometry() != kUnknown_SkPixelGeometry;
- return use_distance_field_text == surface_uses_distance_field_text &&
- can_use_lcd_text == surface_can_use_lcd_text;
+ResourceProvider::ScopedWriteLockGr::~ScopedWriteLockGr() {
+ DCHECK(thread_checker_.CalledOnValidThread());
+ resource_provider_->UnlockForWrite(resource_);
}
ResourceProvider::SynchronousFence::SynchronousFence(
« no previous file with comments | « cc/resources/resource_provider.h ('k') | cc/resources/tile_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698