Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 895693002: Fix issue with multiple properties and emit store. (Closed)

Created:
5 years, 10 months ago by arv (Not doing code reviews)
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix issue with multiple properties and emit store. We used to have a parse error for conflicting property keys. This check was removed to match ES6 (SpiderMonkey & Chakra already made this change). Since this check was removed we ended up with a few new cases when generating code. For example, accessors always generated code even if those should have been shadowed by a data property. BUG=v8:3856 LOG=Y R=adamk, dslomov@chromium.org Committed: https://crrev.com/cd661fdc277a75dec8506f038e3d5904b29de141 Cr-Commit-Position: refs/heads/master@{#26441}

Patch Set 1 #

Patch Set 2 : Cleanup test a bit #

Patch Set 3 : git rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -28 lines) Patch
M src/arm/full-codegen-arm.cc View 1 2 1 chunk +6 lines, -2 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 2 1 chunk +6 lines, -2 lines 0 comments Download
M src/ast.cc View 1 2 2 chunks +17 lines, -10 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 2 1 chunk +6 lines, -2 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 2 1 chunk +6 lines, -2 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 1 2 1 chunk +6 lines, -2 lines 0 comments Download
M src/mips64/full-codegen-mips64.cc View 1 2 1 chunk +6 lines, -2 lines 0 comments Download
M src/ppc/full-codegen-ppc.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 2 1 chunk +6 lines, -2 lines 0 comments Download
M src/x87/full-codegen-x87.cc View 1 2 1 chunk +6 lines, -2 lines 0 comments Download
A test/mjsunit/object-literal-multiple-fields.js View 1 1 chunk +96 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
arv (Not doing code reviews)
Cleanup test a bit
5 years, 10 months ago (2015-02-02 18:04:47 UTC) #1
arv (Not doing code reviews)
PTAL
5 years, 10 months ago (2015-02-02 18:05:18 UTC) #3
adamk
lgtm, but another pair of eyes from dslomov wouldn't hurt.
5 years, 10 months ago (2015-02-02 19:07:25 UTC) #4
arv (Not doing code reviews)
Dmitry, care to take a look?
5 years, 10 months ago (2015-02-02 19:25:35 UTC) #5
arv (Not doing code reviews)
Ping!
5 years, 10 months ago (2015-02-03 16:58:32 UTC) #6
Dmitry Lomov (no reviews)
lgtm
5 years, 10 months ago (2015-02-04 10:42:48 UTC) #7
arv (Not doing code reviews)
git rebase
5 years, 10 months ago (2015-02-04 20:20:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/895693002/40001
5 years, 10 months ago (2015-02-04 20:20:57 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-04 20:44:10 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 20:44:28 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/cd661fdc277a75dec8506f038e3d5904b29de141
Cr-Commit-Position: refs/heads/master@{#26441}

Powered by Google App Engine
This is Rietveld 408576698