|
Fix issue with multiple properties and emit store.
We used to have a parse error for conflicting property keys. This check
was removed to match ES6 (SpiderMonkey & Chakra already made this change).
Since this check was removed we ended up with a few new cases when
generating code. For example, accessors always generated code even if
those should have been shadowed by a data property.
BUG= v8:3856
LOG=Y
R=adamk, dslomov@chromium.org
Committed: https://crrev.com/cd661fdc277a75dec8506f038e3d5904b29de141
Cr-Commit-Position: refs/heads/master@{#26441}
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+167 lines, -28 lines) |
Patch |
|
M |
src/arm/full-codegen-arm.cc
|
View
|
1
2
|
1 chunk |
+6 lines, -2 lines |
0 comments
|
Download
|
|
M |
src/arm64/full-codegen-arm64.cc
|
View
|
1
2
|
1 chunk |
+6 lines, -2 lines |
0 comments
|
Download
|
|
M |
src/ast.cc
|
View
|
1
2
|
2 chunks |
+17 lines, -10 lines |
0 comments
|
Download
|
|
M |
src/compiler/ast-graph-builder.cc
|
View
|
1
2
|
1 chunk |
+6 lines, -2 lines |
0 comments
|
Download
|
|
M |
src/ia32/full-codegen-ia32.cc
|
View
|
1
2
|
1 chunk |
+6 lines, -2 lines |
0 comments
|
Download
|
|
M |
src/mips/full-codegen-mips.cc
|
View
|
1
2
|
1 chunk |
+6 lines, -2 lines |
0 comments
|
Download
|
|
M |
src/mips64/full-codegen-mips64.cc
|
View
|
1
2
|
1 chunk |
+6 lines, -2 lines |
0 comments
|
Download
|
|
M |
src/ppc/full-codegen-ppc.cc
|
View
|
|
1 chunk |
+6 lines, -2 lines |
0 comments
|
Download
|
|
M |
src/x64/full-codegen-x64.cc
|
View
|
1
2
|
1 chunk |
+6 lines, -2 lines |
0 comments
|
Download
|
|
M |
src/x87/full-codegen-x87.cc
|
View
|
1
2
|
1 chunk |
+6 lines, -2 lines |
0 comments
|
Download
|
|
A |
test/mjsunit/object-literal-multiple-fields.js
|
View
|
1
|
1 chunk |
+96 lines, -0 lines |
0 comments
|
Download
|
Total messages: 13 (3 generated)
|