Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Side by Side Diff: src/arm/full-codegen-arm.cc

Issue 895693002: Fix issue with multiple properties and emit store. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: git rebase Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM 7 #if V8_TARGET_ARCH_ARM
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 1740 matching lines...) Expand 10 before | Expand all | Expand 10 after
1751 case ObjectLiteral::Property::PROTOTYPE: 1751 case ObjectLiteral::Property::PROTOTYPE:
1752 // Duplicate receiver on stack. 1752 // Duplicate receiver on stack.
1753 __ ldr(r0, MemOperand(sp)); 1753 __ ldr(r0, MemOperand(sp));
1754 __ push(r0); 1754 __ push(r0);
1755 VisitForStackValue(value); 1755 VisitForStackValue(value);
1756 DCHECK(property->emit_store()); 1756 DCHECK(property->emit_store());
1757 __ CallRuntime(Runtime::kInternalSetPrototype, 2); 1757 __ CallRuntime(Runtime::kInternalSetPrototype, 2);
1758 break; 1758 break;
1759 1759
1760 case ObjectLiteral::Property::GETTER: 1760 case ObjectLiteral::Property::GETTER:
1761 accessor_table.lookup(key)->second->getter = value; 1761 if (property->emit_store()) {
1762 accessor_table.lookup(key)->second->getter = value;
1763 }
1762 break; 1764 break;
1763 case ObjectLiteral::Property::SETTER: 1765 case ObjectLiteral::Property::SETTER:
1764 accessor_table.lookup(key)->second->setter = value; 1766 if (property->emit_store()) {
1767 accessor_table.lookup(key)->second->setter = value;
1768 }
1765 break; 1769 break;
1766 } 1770 }
1767 } 1771 }
1768 1772
1769 // Emit code to define accessors, using only a single call to the runtime for 1773 // Emit code to define accessors, using only a single call to the runtime for
1770 // each pair of corresponding getters and setters. 1774 // each pair of corresponding getters and setters.
1771 for (AccessorTable::Iterator it = accessor_table.begin(); 1775 for (AccessorTable::Iterator it = accessor_table.begin();
1772 it != accessor_table.end(); 1776 it != accessor_table.end();
1773 ++it) { 1777 ++it) {
1774 __ ldr(r0, MemOperand(sp)); // Duplicate receiver. 1778 __ ldr(r0, MemOperand(sp)); // Duplicate receiver.
(...skipping 3655 matching lines...) Expand 10 before | Expand all | Expand 10 after
5430 5434
5431 DCHECK(interrupt_address == 5435 DCHECK(interrupt_address ==
5432 isolate->builtins()->OsrAfterStackCheck()->entry()); 5436 isolate->builtins()->OsrAfterStackCheck()->entry());
5433 return OSR_AFTER_STACK_CHECK; 5437 return OSR_AFTER_STACK_CHECK;
5434 } 5438 }
5435 5439
5436 5440
5437 } } // namespace v8::internal 5441 } } // namespace v8::internal
5438 5442
5439 #endif // V8_TARGET_ARCH_ARM 5443 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698