Domain Reliability: Default to enabled

Domain Reliability: Default to enabled

BUG=

Committed: https://crrev.com/d173a2ebe529d43147c87dafb4d8e2e988728960
Cr-Commit-Position: refs/heads/master@{#316276}

[Deprecated (see juliatuttle), 2015-02-02 17:22:02]

ttuttle@chromium.org changed reviewers:
+ davidben@chromium.org

[Deprecated (see juliatuttle), 2015-02-02 17:22:02]

ttuttle@chromium.org changed required reviewers:
+ davidben@chromium.org

[Deprecated (see juliatuttle), 2015-02-02 17:22:02]

PTAL, davidben.

[davidben, 2015-02-03 19:09:23]

https://codereview.chromium.org/895683002/diff/20001/chrome/browser/browsing_...
File chrome/browser/browsing_data/browsing_data_remover_unittest.cc (right):

https://codereview.chromium.org/895683002/diff/20001/chrome/browser/browsing_...
chrome/browser/browsing_data/browsing_data_remover_unittest.cc:855:
ClearDomainReliabilityTester clear_domain_reliability_tester_;
I don't think we ever interleave private/protected/private like that. If the
ordering matters, how about leave it private and add an accessor? Or stuff it in
a scoped_ptr so you can initialize it later.

https://codereview.chromium.org/895683002/diff/20001/chrome/browser/browsing_...
chrome/browser/browsing_data/browsing_data_remover_unittest.cc:1784:
ClearDomainReliabilityTester& tester = clear_domain_reliability_tester_;
Nit: do we ever use non-const references? Pointer maybe.

[Deprecated (see juliatuttle), 2015-02-03 20:31:39]

PTAL, davidben.

https://codereview.chromium.org/895683002/diff/20001/chrome/browser/browsing_...
File chrome/browser/browsing_data/browsing_data_remover_unittest.cc (right):

https://codereview.chromium.org/895683002/diff/20001/chrome/browser/browsing_...
chrome/browser/browsing_data/browsing_data_remover_unittest.cc:855:
ClearDomainReliabilityTester clear_domain_reliability_tester_;
On 2015/02/03 19:09:23, David Benjamin wrote:
> I don't think we ever interleave private/protected/private like that. If the
> ordering matters, how about leave it private and add an accessor? Or stuff it
in
> a scoped_ptr so you can initialize it later.

Done.

https://codereview.chromium.org/895683002/diff/20001/chrome/browser/browsing_...
chrome/browser/browsing_data/browsing_data_remover_unittest.cc:1784:
ClearDomainReliabilityTester& tester = clear_domain_reliability_tester_;
On 2015/02/03 19:09:23, David Benjamin wrote:
> Nit: do we ever use non-const references? Pointer maybe.

Obsolete; I made it a const reference instead.

[davidben, 2015-02-03 21:16:27]

lgtm

[Deprecated (see juliatuttle), 2015-02-03 22:12:19]

The CQ bit was checked by ttuttle@chromium.org

[commit-bot: I haz the power, 2015-02-03 22:13:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/895683002/40001

[commit-bot: I haz the power, 2015-02-03 22:19:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-03 22:19:12]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Bernhard Bauer, 2015-02-09 18:19:04]

bauerb@chromium.org changed reviewers:
+ bauerb@chromium.org

[Bernhard Bauer, 2015-02-09 18:19:05]

LGTM w/ nits:

https://codereview.chromium.org/895683002/diff/40001/chrome/browser/browsing_...
File chrome/browser/browsing_data/browsing_data_remover_unittest.cc (right):

https://codereview.chromium.org/895683002/diff/40001/chrome/browser/browsing_...
chrome/browser/browsing_data/browsing_data_remover_unittest.cc:1837: //
TODO(ttuttle): This isn't actually testing the no-monitor case, since
So, what's the TODO here?

https://codereview.chromium.org/895683002/diff/40001/chrome/browser/domain_re...
File chrome/browser/domain_reliability/service_factory.cc (right):

https://codereview.chromium.org/895683002/diff/40001/chrome/browser/domain_re...
chrome/browser/domain_reliability/service_factory.cc:25: const char*
kFieldTrialName = "DomRel-Enable";
const char kFieldTrialName[] = "..." etc.?

[Deprecated (see juliatuttle), 2015-02-09 18:33:12]

New patchsets have been uploaded after l-g-t-m from
davidben@chromium.org,bauerb@chromium.org

[Deprecated (see juliatuttle), 2015-02-09 18:35:11]

Thanks!

https://codereview.chromium.org/895683002/diff/40001/chrome/browser/browsing_...
File chrome/browser/browsing_data/browsing_data_remover_unittest.cc (right):

https://codereview.chromium.org/895683002/diff/40001/chrome/browser/browsing_...
chrome/browser/browsing_data/browsing_data_remover_unittest.cc:1837: //
TODO(ttuttle): This isn't actually testing the no-monitor case, since
On 2015/02/09 18:19:04, Bernhard Bauer wrote:
> So, what's the TODO here?

Done.

https://codereview.chromium.org/895683002/diff/40001/chrome/browser/domain_re...
File chrome/browser/domain_reliability/service_factory.cc (right):

https://codereview.chromium.org/895683002/diff/40001/chrome/browser/domain_re...
chrome/browser/domain_reliability/service_factory.cc:25: const char*
kFieldTrialName = "DomRel-Enable";
On 2015/02/09 18:19:05, Bernhard Bauer wrote:
> const char kFieldTrialName[] = "..." etc.?

Done.

[Deprecated (see juliatuttle), 2015-02-09 18:59:19]

The CQ bit was checked by ttuttle@chromium.org

[commit-bot: I haz the power, 2015-02-09 18:59:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/895683002/60001

[commit-bot: I haz the power, 2015-02-09 19:31:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-09 19:31:10]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Deprecated (see juliatuttle), 2015-02-09 20:24:36]

The CQ bit was checked by ttuttle@chromium.org

[commit-bot: I haz the power, 2015-02-09 20:25:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/895683002/60001

[commit-bot: I haz the power, 2015-02-09 21:08:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-09 21:08:27]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Deprecated (see juliatuttle), 2015-02-09 21:14:32]

The CQ bit was checked by ttuttle@chromium.org

[commit-bot: I haz the power, 2015-02-09 21:15:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/895683002/60001

[commit-bot: I haz the power, 2015-02-09 22:13:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-09 22:14:01]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Deprecated (see juliatuttle), 2015-02-09 23:49:28]

The CQ bit was checked by ttuttle@chromium.org

[commit-bot: I haz the power, 2015-02-09 23:50:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/895683002/60001

[commit-bot: I haz the power, 2015-02-10 00:37:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-10 00:37:47]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Deprecated (see juliatuttle), 2015-02-10 16:09:38]

The CQ bit was checked by ttuttle@chromium.org

[commit-bot: I haz the power, 2015-02-10 16:10:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/895683002/60001

[commit-bot: I haz the power, 2015-02-10 16:50:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-10 16:50:09]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Deprecated (see juliatuttle), 2015-02-13 18:59:35]

The CQ bit was checked by ttuttle@chromium.org

[commit-bot: I haz the power, 2015-02-13 19:00:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/895683002/100001

[Deprecated (see juliatuttle), 2015-02-13 19:58:49]

The CQ bit was checked by ttuttle@chromium.org

[commit-bot: I haz the power, 2015-02-13 19:59:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/895683002/120001

[commit-bot: I haz the power, 2015-02-13 20:31:50]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2015-02-13 20:33:05]

Patchset 7 (id:??) landed as
https://crrev.com/d173a2ebe529d43147c87dafb4d8e2e988728960
Cr-Commit-Position: refs/heads/master@{#316276}