Domain Reliability: Default to enabled

chrome/browser/domain_reliability/service_factory.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/domain_reliability/service_factory.h"
 
 #include "base/command_line.h"
 #include "base/metrics/field_trial.h"
 #include "base/prefs/pref_service.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/pref_names.h"
 #include "components/domain_reliability/service.h"
 #include "components/keyed_service/content/browser_context_dependency_manager.h"
 #include "content/public/browser/browser_context.h"
 
 namespace domain_reliability {
 
 namespace {
 
+// If Domain Reliability is enabled in the absence of a flag or field trial.
+const bool kDefaultEnabled = true;
+
+// The name and value of the field trial to turn Domain Reliability on.
+const char* kFieldTrialName = "DomRel-Enable";

[Bernhard Bauer, 2015/02/09 18:19:05]

const char kFieldTrialName[] = "..." etc.?

[Deprecated (see juliatuttle), 2015/02/09 18:35:11]

Done.

+const char* kFieldTrialValueEnable = "enable";
+
 // Identifies Chrome as the source of Domain Reliability uploads it sends.
-const char* kDomainReliabilityUploadReporterString = "chrome";
+const char* kUploadReporterString = "chrome";
 
 bool IsDomainReliabilityMonitoringEnabled() {
   base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
   if (command_line->HasSwitch(switches::kDisableDomainReliability))
     return false;
   if (command_line->HasSwitch(switches::kEnableDomainReliability))
     return true;
-  return base::FieldTrialList::FindFullName("DomRel-Enable") == "enable";
+
+  if (base::FieldTrialList::TrialExists(kFieldTrialName)) {
+    std::string value = base::FieldTrialList::FindFullName(kFieldTrialName);
+    return value == kFieldTrialValueEnable;
+  }
+
+  return kDefaultEnabled;
 }
 
 }  // namespace
 
 // static
 DomainReliabilityService*
 DomainReliabilityServiceFactory::GetForBrowserContext(
     content::BrowserContext* context) {
   return static_cast<DomainReliabilityService*>(
       GetInstance()->GetServiceForBrowserContext(context,
@@ skipping 16 matching lines @@
 KeyedService* DomainReliabilityServiceFactory::BuildServiceInstanceFor(
     content::BrowserContext* context) const {
   if (!IsDomainReliabilityMonitoringEnabled())
     return NULL;
 
   if (!g_browser_process->local_state()->GetBoolean(
           prefs::kMetricsReportingEnabled)) {
     return NULL;
   }
 
-  return DomainReliabilityService::Create(
-      kDomainReliabilityUploadReporterString);
+  return DomainReliabilityService::Create(kUploadReporterString);
 }
 
 }  // namespace domain_reliability