Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1916)

Unified Diff: chrome/browser/password_manager/native_backend_libsecret_unittest.cc

Issue 895653002: Serialize date_created in PasswordStoreX properly (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/native_backend_libsecret_unittest.cc
diff --git a/chrome/browser/password_manager/native_backend_libsecret_unittest.cc b/chrome/browser/password_manager/native_backend_libsecret_unittest.cc
index b7ae4be0ab034cf0484915a62bd5396cf6368b0e..cc8a1fa3e0e4295f13480903b021bcb269677a88 100644
--- a/chrome/browser/password_manager/native_backend_libsecret_unittest.cc
+++ b/chrome/browser/password_manager/native_backend_libsecret_unittest.cc
@@ -236,8 +236,7 @@ void CheckPasswordChanges(const PasswordStoreChangeList& expected_list,
EXPECT_EQ(expected.signon_realm, actual.signon_realm);
EXPECT_EQ(expected.ssl_valid, actual.ssl_valid);
EXPECT_EQ(expected.preferred, actual.preferred);
- // We don't check the date created. It varies due to bug in the
- // serialization. Integer seconds are saved instead of microseconds.
+ EXPECT_EQ(expected.date_created, actual.date_created);
EXPECT_EQ(expected.blacklisted_by_user, actual.blacklisted_by_user);
EXPECT_EQ(expected.type, actual.type);
EXPECT_EQ(expected.times_used, actual.times_used);
@@ -528,15 +527,13 @@ class NativeBackendLibsecretTest : public testing::Test {
void CheckRemoveLoginsBetween(RemoveBetweenMethod date_to_test) {
NativeBackendLibsecret backend(42);
- form_google_.date_synced = base::Time();
- form_isc_.date_synced = base::Time();
- form_google_.date_created = base::Time();
- form_isc_.date_created = base::Time();
base::Time now = base::Time::Now();
base::Time next_day = now + base::TimeDelta::FromDays(1);
+ form_google_.date_synced = base::Time();
+ form_isc_.date_synced = base::Time();
+ form_google_.date_created = now;
+ form_isc_.date_created = now;
if (date_to_test == CREATED) {
- // http://crbug.com/374132. Remove the next line once it's fixed.
- next_day = base::Time::FromTimeT(next_day.ToTimeT());
form_google_.date_created = now;
form_isc_.date_created = next_day;
} else {
@@ -573,6 +570,7 @@ class NativeBackendLibsecretTest : public testing::Test {
result = base::Bind(method, base::Unretained(&backend), next_day,
base::Time(), &changes).Run();
+
CheckPasswordChangesWithResult(&expected_changes, &changes, result);
EXPECT_EQ(0u, global_mock_libsecret_items.size());

Powered by Google App Engine
This is Rietveld 408576698