Serialize date_created in PasswordStoreX properly

chrome/browser/password_manager/native_backend_libsecret_unittest.cc

 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stdarg.h>
 
 #include "base/basictypes.h"
 #include "base/prefs/pref_service.h"
 #include "base/stl_util.h"
 #include "base/strings/string_number_conversions.h"
@@ skipping 218 matching lines @@
     EXPECT_EQ(expected.origin, actual.origin);
     EXPECT_EQ(expected.password_value, actual.password_value);
     EXPECT_EQ(expected.action, actual.action);
     EXPECT_EQ(expected.username_element, actual.username_element);
     EXPECT_EQ(expected.username_value, actual.username_value);
     EXPECT_EQ(expected.password_element, actual.password_element);
     EXPECT_EQ(expected.submit_element, actual.submit_element);
     EXPECT_EQ(expected.signon_realm, actual.signon_realm);
     EXPECT_EQ(expected.ssl_valid, actual.ssl_valid);
     EXPECT_EQ(expected.preferred, actual.preferred);
-    // We don't check the date created. It varies due to bug in the
-    // serialization. Integer seconds are saved instead of microseconds.
+    EXPECT_EQ(expected.date_created, actual.date_created);
     EXPECT_EQ(expected.blacklisted_by_user, actual.blacklisted_by_user);
     EXPECT_EQ(expected.type, actual.type);
     EXPECT_EQ(expected.times_used, actual.times_used);
     EXPECT_EQ(expected.scheme, actual.scheme);
     EXPECT_EQ(expected.date_synced, actual.date_synced);
     EXPECT_EQ(expected.display_name, actual.display_name);
     EXPECT_EQ(expected.avatar_url, actual.avatar_url);
     EXPECT_EQ(expected.federation_url, actual.federation_url);
     EXPECT_EQ(expected.is_zero_click, actual.is_zero_click);
   }
@@ skipping 270 matching lines @@
     EXPECT_FALSE(CheckCredentialAvailability(
         other_auth_, GURL("http://first.example.com"), scheme, nullptr));
     // Do match non-HTML forms from the same origin.
     EXPECT_TRUE(CheckCredentialAvailability(
         other_auth_, GURL("http://www.example.com/"), scheme, nullptr));
   }
 
   void CheckRemoveLoginsBetween(RemoveBetweenMethod date_to_test) {
     NativeBackendLibsecret backend(42);
 
+    base::Time now = base::Time::Now();
+    base::Time next_day = now + base::TimeDelta::FromDays(1);
     form_google_.date_synced = base::Time();
     form_isc_.date_synced = base::Time();
-    form_google_.date_created = base::Time();
-    form_isc_.date_created = base::Time();
-    base::Time now = base::Time::Now();
-    base::Time next_day = now + base::TimeDelta::FromDays(1);
+    form_google_.date_created = now;
+    form_isc_.date_created = now;
     if (date_to_test == CREATED) {
-      // http://crbug.com/374132. Remove the next line once it's fixed.
-      next_day = base::Time::FromTimeT(next_day.ToTimeT());
       form_google_.date_created = now;
       form_isc_.date_created = next_day;
     } else {
       form_google_.date_synced = now;
       form_isc_.date_synced = next_day;
     }
 
     backend.AddLogin(form_google_);
     backend.AddLogin(form_isc_);
 
@@ skipping 16 matching lines @@
       CheckMockSecretItem(global_mock_libsecret_items[0], form_isc_,
                           "chrome-42");
 
     // Remove form_isc_.
     expected_changes.clear();
     expected_changes.push_back(
         PasswordStoreChange(PasswordStoreChange::REMOVE, form_isc_));
 
     result = base::Bind(method, base::Unretained(&backend), next_day,
                         base::Time(), &changes).Run();
+
     CheckPasswordChangesWithResult(&expected_changes, &changes, result);
 
     EXPECT_EQ(0u, global_mock_libsecret_items.size());
   }
 
   base::MessageLoopForUI message_loop_;
 
   // Provide some test forms to avoid having to set them up in each test.
   PasswordForm form_google_;
   PasswordForm form_facebook_;
@@ skipping 250 matching lines @@
 
   ScopedVector<autofill::PasswordForm> form_list;
   backend.GetAutofillableLogins(&form_list);
 
   EXPECT_EQ(1u, form_list.size());
   EXPECT_EQ(GURL(""), form_list[0]->avatar_url);
   EXPECT_FALSE(form_list[0]->ssl_valid);
 }
 
 // TODO(mdm): add more basic tests here at some point.