Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 895633002: Gatekeeper: use same authentication for reading status as for writing. (Closed)

Created:
5 years, 10 months ago by tandrii(chromium)
Modified:
5 years, 10 months ago
CC:
chromium-reviews, pgervais+watch_chromium.org, kjellander-cc_chromium.org, cmp-cc_chromium.org, stip+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Gatekeeper: use same authentication for reading status as for writing. Based on https://codereview.chromium.org/891713003/ R=stip@chromium.org BUG=453319 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=293940

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -6 lines) Patch
M scripts/slave/gatekeeper_ng.py View 3 chunks +21 lines, -4 lines 0 comments Download
M scripts/slave/unittests/gatekeeper_ng_test.py View 3 chunks +21 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
tandrii(chromium)
PTAL with companion CL for status app https://codereview.chromium.org/891713003/
5 years, 10 months ago (2015-02-02 15:55:20 UTC) #1
ghost stip (do not use)
lgtm
5 years, 10 months ago (2015-02-02 21:17:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/895633002/1
5 years, 10 months ago (2015-02-04 11:08:45 UTC) #4
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 11:11:43 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=293940

Powered by Google App Engine
This is Rietveld 408576698