Gatekeeper: use same authentication for reading status as for writing.

scripts/slave/unittests/gatekeeper_ng_test.py

 #!/usr/bin/env python
 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Unit tests for gatekeeper_ng.py.
 
 This is a basic check that gatekeeper_ng.py can properly interpret builds and
 close the tree.
 
@@ skipping 354 matching lines @@
       params = req.get_data()
     else:
       url = req
 
     call = {'url': url}
     if params:
       call['params'] = params
     self.url_calls.append(call)
 
     if url in self.urls:
-      return copy.copy(self.urls[url])
+      return copy.copy(self.urls[url](params))
     else:
       raise urllib2.HTTPError(url, 404, 'Not Found: %s' % url,
                               None, StringIO.StringIO(''))
 
   @staticmethod
   def decode_param_json(param):
     data = urlparse.parse_qs(param)
     payload = json.loads(data['json'][0])['message']
     return json.loads(payload)
 
   def handle_url_fp(self, url, fp):
     """Add a file object to handle a mocked URL."""
     setattr(fp, 'getcode', lambda: 200)
-    self.urls[url] = fp
+    self.urls[url] = lambda _: fp
+
+  def handle_url_custom(self, url, handler):
+    """Handler func will be called with params as first argument."""
+    self.urls[url] = handler
 
   def handle_url_str(self, url, response):
     """Add a string to handle a mocked URL."""
     buf = StringIO.StringIO(response)
     self.handle_url_fp(url, buf)
 
   def handle_url_json(self, url, data):
     """Add a json object to handle a mocked URL."""
     buf = StringIO.StringIO()
     json.dump(data, buf)
@@ skipping 374 matching lines @@
     self.handle_url_json(self.get_status_url, {
       'message': 'closed (automatic)',
       'general_state': 'closed',
     })
     self.call_gatekeeper(build_db=build_db)
     self.assertEquals(self.url_calls[-1]['url'], self.set_status_url)
     status_data = urlparse.parse_qs(self.url_calls[-1]['params'])
     self.assertTrue(status_data['message'][0].startswith(
       "Tree is open (Automatic"))
 
+    # Same as above and get_status_url requires bot login.
+    json_handler = self.urls.pop(self.get_status_url)
+    def handler(params):
+      if params == None:
+        return StringIO.StringIO("<blabla>Login Required</blabla>")
+      else:
+        return json_handler(params)
+    self.handle_url_custom(self.get_status_url, handler)
+    self.call_gatekeeper(build_db=build_db)
+    self.assertEquals(self.url_calls[-2]['url'], self.get_status_url)
+    self.assertIsNotNone(self.url_calls[-2]['params'])
+    status_data = urlparse.parse_qs(self.url_calls[-1]['params'])
+    self.assertTrue(status_data['message'][0].startswith(
+      "Tree is open (Automatic"))
+
     # However, don't touch the tree status if a human set it.
     self.handle_url_json(self.get_status_url, {
       'message': 'closed, world is on fire',
       'general_state': 'closed',
     })
     urls = self.call_gatekeeper(build_db=build_db)
     self.assertNotIn(self.set_status_url, urls)
 
     # Only change the tree status if it's currently 'closed'
     self.handle_url_json(self.get_status_url, {
@@ skipping 1960 matching lines @@
         json=os.path.join(SCRIPT_DIR, os.pardir, 'gatekeeper.json'))
 
   def testCheckedInTreeConfigIsValid(self): # pylint: disable=R0201
     tree_config = os.path.join(SCRIPT_DIR, os.pardir, 'gatekeeper_trees.json')
     gatekeeper_ng_config.load_gatekeeper_tree_config(tree_config)
 
 
 if __name__ == '__main__':
   with utils.print_coverage(include=[__file__]):
     unittest.main()