Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 895433005: revert a057427e02b14f2f7851 (Closed)

Created:
5 years, 10 months ago by Evan Stade
Modified:
5 years, 10 months ago
Reviewers:
newt (away)
CC:
chromium-reviews, ankitkumar
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

revert a057427e02b14f2f7851 Added code to disable save button if no text is present in name or number field Currently if some text is first typed in any of the fields then save button gets enabled. But when all text is deleted from field, save button is not disabled. Added code to enable/disable properly. BUG=446760 Review URL: https://codereview.chromium.org/837613003 It created a new bug, http://crbug.com/453568, and the original issue it solved is not worth fixing. BUG=453568, 446760 Committed: https://crrev.com/46a39fbe28de7a49924d8ef6267f8b44f1cf0a32 Cr-Commit-Position: refs/heads/master@{#314935}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -6 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardEditor.java View 5 chunks +20 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Evan Stade
I apologize for reviewing the last change without taking a close look at the bug ...
5 years, 10 months ago (2015-02-05 22:45:54 UTC) #2
newt (away)
lgtm How many CLs can we have surrounding these Save buttons? :P
5 years, 10 months ago (2015-02-06 00:16:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/895433005/1
5 years, 10 months ago (2015-02-06 00:21:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-06 01:06:37 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 01:07:35 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/46a39fbe28de7a49924d8ef6267f8b44f1cf0a32
Cr-Commit-Position: refs/heads/master@{#314935}

Powered by Google App Engine
This is Rietveld 408576698