Added code to disable save button if no text is present in name or number field

Added code to disable save button if no text is present in name or number field

Currently if some text is first typed in any of the fields then save button
gets enabled. But when all text is deleted from field, save button is not
disabled.
Added code to enable/disable properly.

BUG=446760
Committed: https://crrev.com/a057427e02b14f2f7851c9e5a6926bb46c7b50d7
Cr-Commit-Position: refs/heads/master@{#311849}

[ankitkumar, 2015-01-07 07:12:39]

ankitkumar@chromium.org changed reviewers:
+ bauerb@chromium.org, newt@chromium.org

[ankitkumar, 2015-01-07 07:12:40]

PTAL

[newt (away), 2015-01-07 16:12:29]

newt@chromium.org changed reviewers:
+ estade@chromium.org

[newt (away), 2015-01-07 16:12:29]

estade: Could you review this since you're most familiar with how autofill
credit cards should work?

[Evan Stade, 2015-01-07 22:56:59]

https://codereview.chromium.org/837613003/diff/1/chrome/android/java/src/org/...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardEditor.java
(right):

https://codereview.chromium.org/837613003/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardEditor.java:234:
private void enableSaveButton() {
I'd change the name of this function to updateSaveButtonState or some such,
otherwise lgtm

[ankitkumar, 2015-01-08 04:34:53]

https://codereview.chromium.org/837613003/diff/1/chrome/android/java/src/org/...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardEditor.java
(right):

https://codereview.chromium.org/837613003/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardEditor.java:234:
private void enableSaveButton() {
On 2015/01/07 22:56:59, Evan Stade wrote:
> I'd change the name of this function to updateSaveButtonState or some such,
> otherwise lgtm

Done.

[ankitkumar, 2015-01-08 04:34:59]

The CQ bit was checked by ankitkumar@chromium.org

[commit-bot: I haz the power, 2015-01-08 04:36:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/837613003/20001

[commit-bot: I haz the power, 2015-01-08 04:43:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-08 04:43:04]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[ankitkumar, 2015-01-08 04:51:10]

ankitkumar@chromium.org changed reviewers:
- bauerb@chromium.org

[ankitkumar, 2015-01-08 04:51:10]

@Newt
PTAL.
lgtm is missing from owner

[newt (away), 2015-01-08 17:51:38]

https://codereview.chromium.org/837613003/diff/20001/chrome/android/java/src/...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardEditor.java
(right):

https://codereview.chromium.org/837613003/diff/20001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardEditor.java:93:
updateSaveButtonState();
There's no point in calling updateSaveButtonState() here since the save button
state won't change as a result of the user changing the expiration month or
year.

[ankitkumar, 2015-01-09 11:43:38]

@newt
PTAL

https://codereview.chromium.org/837613003/diff/20001/chrome/android/java/src/...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardEditor.java
(right):

https://codereview.chromium.org/837613003/diff/20001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardEditor.java:93:
updateSaveButtonState();
On 2015/01/08 17:51:37, newt wrote:
> There's no point in calling updateSaveButtonState() here since the save button
> state won't change as a result of the user changing the expiration month or
> year.

Acknowledged. Removed this call.

[newt (away), 2015-01-12 18:56:10]

https://codereview.chromium.org/837613003/diff/40001/chrome/android/java/src/...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardEditor.java
(right):

https://codereview.chromium.org/837613003/diff/40001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardEditor.java:32:
public class AutofillCreditCardEditor extends Fragment implements
OnItemSelectedListener,
Looks like this class doesn't need to implement OnItemSelectedListener anymore.
Please remove this interface.

[ankitkumar, 2015-01-13 03:50:53]

@newt
PTAL at comment and share your opinion

https://codereview.chromium.org/837613003/diff/40001/chrome/android/java/src/...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardEditor.java
(right):

https://codereview.chromium.org/837613003/diff/40001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardEditor.java:32:
public class AutofillCreditCardEditor extends Fragment implements
OnItemSelectedListener,
On 2015/01/12 18:56:10, newt wrote:
> Looks like this class doesn't need to implement OnItemSelectedListener
anymore.
> Please remove this interface.

Agreed.
Actually I have found some more redundant codes related to autofill. I am
planning to do a follow up patch for removing redundant code. Please let me know
if that's fine. Otherwise we can remove it in this patch only.

[newt (away), 2015-01-13 04:12:07]

On 2015/01/13 03:50:53, ankitkumar wrote:
> @newt
> PTAL at comment and share your opinion
> 
>
https://codereview.chromium.org/837613003/diff/40001/chrome/android/java/src/...
> File
>
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardEditor.java
> (right):
> 
>
https://codereview.chromium.org/837613003/diff/40001/chrome/android/java/src/...
>
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardEditor.java:32:
> public class AutofillCreditCardEditor extends Fragment implements
> OnItemSelectedListener,
> On 2015/01/12 18:56:10, newt wrote:
> > Looks like this class doesn't need to implement OnItemSelectedListener
> anymore.
> > Please remove this interface.
> 
> Agreed.
> Actually I have found some more redundant codes related to autofill. I am
> planning to do a follow up patch for removing redundant code. Please let me
know
> if that's fine. Otherwise we can remove it in this patch only.

You should definitely remove OnItemSelectedListener in this CL, since it's
directly related to the change you're making. You can save other cleanup for a
later CL, or if it's a very small amount of cleanup in this same file, you can
squeeze it into this CL.

[ankitkumar, 2015-01-14 06:06:22]

@newt
PTAL at new patch.
I have made changes as suggested.

[newt (away), 2015-01-14 15:42:54]

lgtm

[ankitkumar, 2015-01-15 04:11:31]

On 2015/01/14 15:42:54, newt wrote:
> lgtm

Thanks

[ankitkumar, 2015-01-15 04:11:35]

The CQ bit was checked by ankitkumar@chromium.org

[commit-bot: I haz the power, 2015-01-15 04:12:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/837613003/60001

[commit-bot: I haz the power, 2015-01-15 05:13:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-15 05:13:59]

Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[ankitkumar, 2015-01-15 09:20:32]

The CQ bit was checked by ankitkumar@chromium.org

[commit-bot: I haz the power, 2015-01-15 09:21:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/837613003/60001

[commit-bot: I haz the power, 2015-01-15 09:21:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-15 09:21:51]

Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[ankitkumar, 2015-01-16 06:32:35]

The CQ bit was checked by ankitkumar@chromium.org

[commit-bot: I haz the power, 2015-01-16 06:33:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/837613003/70001

[commit-bot: I haz the power, 2015-01-16 07:09:28]

Committed patchset #5 (id:70001)

[commit-bot: I haz the power, 2015-01-16 07:10:16]

Patchset 5 (id:??) landed as
https://crrev.com/a057427e02b14f2f7851c9e5a6926bb46c7b50d7
Cr-Commit-Position: refs/heads/master@{#311849}