Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 895383002: Let StyleResolver figure out differences between UA style and resolved style. (Closed)

Created:
5 years, 10 months ago by andersr
Modified:
5 years, 10 months ago
Reviewers:
Timothy Loh
CC:
blink-reviews, blink-reviews-rendering, zoltan1, blink-reviews-css, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, ed+blinkwatch_opera.com, leviw+renderwatch, Dominik Röttsches, dglazkov+blink, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Let StyleResolver figure out differences between UA style and resolved style. We currently pass a CachedUAStyle out of StyleResolver and let LayoutTheme figure out the background/border differences between UA style, and the fully resolved style. This is not ideal, because it requires the diffing to take place in a specific way, making it hard to make changes to how the diff is produced. This patch passes an object UAStyleChange to LayoutTheme, pre-filled with the result of the diff. R=timloh@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189912

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase. #

Patch Set 3 : AuthorStyleInfo. #

Patch Set 4 : Don't remove check for !style.hasAppearance(). #

Patch Set 5 : Mac compile fix. #

Patch Set 6 : "Rebase". #

Patch Set 7 : Fix assert. #

Patch Set 8 : I mean *remove* assert. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -35 lines) Patch
M Source/core/core.gypi View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/resolver/StyleAdjuster.h View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/resolver/StyleAdjuster.cpp View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.h View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 1 2 3 4 5 1 chunk +23 lines, -1 line 0 comments Download
M Source/core/layout/LayoutTheme.h View 1 2 3 4 5 4 chunks +3 lines, -3 lines 0 comments Download
M Source/core/layout/LayoutTheme.cpp View 1 2 3 4 5 6 7 5 chunks +8 lines, -22 lines 0 comments Download
M Source/core/layout/LayoutThemeChromiumMac.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutThemeChromiumMac.mm View 1 2 3 4 5 3 chunks +4 lines, -4 lines 0 comments Download
A Source/core/layout/style/AuthorStyleInfo.h View 1 2 3 4 5 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
andersr
Based https://codereview.chromium.org/361173002 . I prefer to do this before the CascadedValues patch rather than after, ...
5 years, 10 months ago (2015-02-04 12:17:50 UTC) #1
Timothy Loh
lgtm I don't really get the name UAStyleChange (but I have no better suggestions). Could ...
5 years, 10 months ago (2015-02-06 00:20:29 UTC) #2
andersr
PTAL. > I don't really get the name UAStyleChange How about now?
5 years, 10 months ago (2015-02-10 09:45:12 UTC) #4
Timothy Loh
On 2015/02/10 09:45:12, andersr wrote: > PTAL. > > > I don't really get the ...
5 years, 10 months ago (2015-02-10 14:39:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/895383002/130001
5 years, 10 months ago (2015-02-10 14:49:05 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-10 17:27:21 UTC) #8
Message was sent while issue was closed. 
Committed patchset #8 (id:130001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189912

Powered by Google App Engine
This is Rietveld 408576698