Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 895373002: Revert of Start moving ownership of SyncNotificationController to SyncController. (Closed)

Created:
5 years, 10 months ago by perezju
Modified:
5 years, 10 months ago
Reviewers:
nyquist, maxbogue
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, mlamouri+watch-notifications_chromium.org, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, peter+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Start moving ownership of SyncNotificationController to SyncController. (patchset #3 id:40001 of https://codereview.chromium.org/889723002/) Reason for revert: Broke downstream builds Original issue's description: > Start moving ownership of SyncNotificationController to SyncController. > > GoogleServicesNotificationController is modified to work > the way most other singleton classes work, so that it is > not necessary to pass into the SyncNotificationController > constructor (and thus, into SyncController in the future). > > SyncController gets a temporary setter method so that SNC > can be constructed downstream and passed in until all its > dependencies are upstream. > > BUG=428882 > > Committed: https://crrev.com/deaa0fe6ca3e0428a85fc22b019819437d84120b > Cr-Commit-Position: refs/heads/master@{#314515} TBR=nyquist@chromium.org,maxbogue@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=428882 Committed: https://crrev.com/0d4fcfbcbc0fc0b06c454d4a8706262a007eabba Cr-Commit-Position: refs/heads/master@{#314537}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -59 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/notifications/GoogleServicesNotificationController.java View 4 chunks +20 lines, -22 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/sync/SyncController.java View 2 chunks +0 lines, -22 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/sync/SyncNotificationController.java View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
perezju
Created Revert of Start moving ownership of SyncNotificationController to SyncController.
5 years, 10 months ago (2015-02-04 10:55:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/895373002/1
5 years, 10 months ago (2015-02-04 10:56:02 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-04 10:57:03 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 10:59:13 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0d4fcfbcbc0fc0b06c454d4a8706262a007eabba
Cr-Commit-Position: refs/heads/master@{#314537}

Powered by Google App Engine
This is Rietveld 408576698