Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1813)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/sync/SyncController.java

Issue 895373002: Revert of Start moving ownership of SyncNotificationController to SyncController. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/sync/SyncController.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/sync/SyncController.java b/chrome/android/java/src/org/chromium/chrome/browser/sync/SyncController.java
index a6b67e8c95dd28ee2cdefd02a9a7d47ea6b240a3..55664d776a2af9862d03f6ce4921aead9fc2236d 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/sync/SyncController.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/sync/SyncController.java
@@ -42,8 +42,6 @@
private final ChromeSigninController mChromeSigninController;
private final AndroidSyncSettings mAndroidSyncSettings;
private final ProfileSyncService mProfileSyncService;
- // TODO(maxbogue): Make final once it's constructed in this class.
- private SyncNotificationController mSyncNotificationController = null;
private SyncController(Context context) {
mContext = context;
@@ -188,24 +186,4 @@
}
});
}
-
- /**
- * Sets the SyncNotificationController.
- *
- * This is a temporary method for transferring ownership of SyncNotificationController
- * upstream. Once all of SNC's dependencies are upstreamed, it will be created in the
- * SyncController constructor and this method won't exist.
- */
- public void setSyncNotificationController(SyncNotificationController snc) {
- assert mSyncNotificationController == null;
- mSyncNotificationController = snc;
- mProfileSyncService.addSyncStateChangedListener(mSyncNotificationController);
- }
-
- /**
- * Returns the SyncNotificationController.
- */
- public SyncNotificationController getSyncNotificationController() {
- return mSyncNotificationController;
- }
}

Powered by Google App Engine
This is Rietveld 408576698