Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Issue 895363007: [OSX] Handle PermissionBubble coalescing (Closed)

Created:
5 years, 10 months ago by groby-ooo-7-16
Modified:
5 years, 7 months ago
Reviewers:
felt
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[OSX] Handle PermissionBubble coalescing PermissionBubbleCocoa::CanAcceptRequestUpdate controls request coalescing. This change allows requests to be added to an existing permission bubble unless the user has moused over the bubble. BUG=452931 Committed: https://crrev.com/2f435c4d5e6356e9a4506d4c725ffad3eb7aa16d Cr-Commit-Position: refs/heads/master@{#327365}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.mm View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
groby-ooo-7-16
PTAL Implements the equivalent of the Views code. This is a good-faith implementation, since the ...
5 years, 8 months ago (2015-04-23 05:45:00 UTC) #2
felt
lgtm... as a basic sniff test. I don't know enough about Mac to know if ...
5 years, 8 months ago (2015-04-24 15:57:59 UTC) #3
groby-ooo-7-16
On 2015/04/24 15:57:59, felt wrote: > lgtm... as a basic sniff test. I don't know ...
5 years, 7 months ago (2015-04-28 20:30:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/895363007/1
5 years, 7 months ago (2015-04-28 20:30:56 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-28 21:35:47 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 21:36:30 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2f435c4d5e6356e9a4506d4c725ffad3eb7aa16d
Cr-Commit-Position: refs/heads/master@{#327365}

Powered by Google App Engine
This is Rietveld 408576698