Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1053)

Unified Diff: chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.mm

Issue 895363007: [OSX] Handle PermissionBubble coalescing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.mm
diff --git a/chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.mm b/chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.mm
index 4370ec25fa348a916f2491e0636a370d3cb08fa5..57eff4b5871981e72b2eb9a5a151536b58cddd82 100644
--- a/chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.mm
+++ b/chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.mm
@@ -10,6 +10,7 @@
#import "chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h"
#import "chrome/browser/ui/website_settings/permission_bubble_view.h"
#include "content/public/browser/web_contents.h"
+#import "ui/base/cocoa/nsview_additions.h"
PermissionBubbleCocoa::PermissionBubbleCocoa(NSWindow* parent_window)
: parent_window_(parent_window), delegate_(NULL), bubbleController_(nil) {}
@@ -55,9 +56,7 @@ void PermissionBubbleCocoa::SetDelegate(Delegate* delegate) {
}
bool PermissionBubbleCocoa::CanAcceptRequestUpdate() {
- // TODO(gbillock): implement. Should return true if the mouse is not over the
- // dialog.
- return false;
+ return ![[[bubbleController_ window] contentView] cr_isMouseInView];
}
void PermissionBubbleCocoa::OnBubbleClosing() {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698