win: convert MinidumpSimpleStringDictionaryWriter to scoped_ptr

win: convert MinidumpSimpleStringDictionaryWriter to scoped_ptr

Had to move this one out to a scoped_ptr too, otherwise when
it's instantiated in test code on the stack,

d:\src\crashpad\crashpad\minidump\minidump_simple_string_dictionary_writer_test.cc(45) : warning C4815: 'dictionary_writer' : zero-sized array in stack object will have no elements (unless the object is an aggregate that has been aggregate initialized)

R=mark@chromium.org
BUG=crashpad:1
Committed: https://chromium.googlesource.com/crashpad/crashpad/+/3162f1259c9b9690980c90d221d40d47f915f744

[Mark Mentovai, 2015-02-05 14:20:26]

LGTM

[Mark Mentovai, 2015-02-05 14:21:58]

LGTM still

https://codereview.chromium.org/895313004/diff/20001/snapshot/snapshot.gyp
File snapshot/snapshot.gyp (right):

https://codereview.chromium.org/895313004/diff/20001/snapshot/snapshot.gyp#ne...
snapshot/snapshot.gyp:82: '../compat/compat.gyp:compat',
https://codereview.chromium.org/897973003/ is dedicated to this change, remove
it from this changelist.

[scottmg, 2015-02-05 16:40:55]

New patchsets have been uploaded after l-g-t-m from mark@chromium.org

[scottmg, 2015-02-05 16:41:05]

On 2015/02/05 14:21:58, Mark Mentovai wrote:
> LGTM still
> 
> https://codereview.chromium.org/895313004/diff/20001/snapshot/snapshot.gyp
> File snapshot/snapshot.gyp (right):
> 
>
https://codereview.chromium.org/895313004/diff/20001/snapshot/snapshot.gyp#ne...
> snapshot/snapshot.gyp:82: '../compat/compat.gyp:compat',
> https://codereview.chromium.org/897973003/ is dedicated to this change, remove
> it from this changelist.

Oops, thanks. Done.

[scottmg, 2015-02-05 16:41:20]

Committed patchset #3 (id:40001) manually as
3162f1259c9b9690980c90d221d40d47f915f744 (presubmit successful).