minidump/minidump_simple_string_dictionary_writer.h - Issue 895313004: win: convert MinidumpSimpleStringDictionaryWriter to scoped_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: minidump/minidump_simple_string_dictionary_writer.h

Issue 895313004: win: convert MinidumpSimpleStringDictionaryWriter to scoped_ptr (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: remove mistaken addition Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: minidump/minidump_simple_string_dictionary_writer.h

diff --git a/minidump/minidump_simple_string_dictionary_writer.h b/minidump/minidump_simple_string_dictionary_writer.h

index 2d195532c9b9d749f0d2c837e20787c422a515af..88059bd8eb54c608554ad99565f763de46e73cb6 100644

--- a/minidump/minidump_simple_string_dictionary_writer.h

+++ b/minidump/minidump_simple_string_dictionary_writer.h

@@ -135,7 +135,7 @@ class MinidumpSimpleStringDictionaryWriter final

// This object owns the MinidumpSimpleStringDictionaryEntryWriter objects.

std::map<std::string, MinidumpSimpleStringDictionaryEntryWriter*> entries_;

- MinidumpSimpleStringDictionary simple_string_dictionary_base_;

+ scoped_ptr<MinidumpSimpleStringDictionary> simple_string_dictionary_base_;

DISALLOW_COPY_AND_ASSIGN(MinidumpSimpleStringDictionaryWriter);

};

« no previous file with comments | « no previous file | minidump/minidump_simple_string_dictionary_writer.cc » ('j') | no next file with comments »