Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 895093003: Change ListThumbnailLoader to use ThumbnailLoader.loadAsDataUrl. (Closed)

Created:
5 years, 10 months ago by yawano
Modified:
5 years, 10 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change ListThumbnailLoader to use ThumbnailLoader.loadAsDataUrl. BUG=438050 TEST=out/Release/browser_tests --gtest_filter=FileManagerJsTest.ListThumbnailLoader Committed: https://crrev.com/79796fe5810a16b29223f0f7f7bda9054012cf00 Cr-Commit-Position: refs/heads/master@{#314795}

Patch Set 1 #

Patch Set 2 : Remove a TODO. #

Patch Set 3 : Fix comment. #

Total comments: 2

Patch Set 4 : Fix type annotation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -70 lines) Patch
M ui/file_manager/file_manager/foreground/js/list_thumbnail_loader.js View 1 2 3 5 chunks +51 lines, -41 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/list_thumbnail_loader_unittest.js View 2 chunks +22 lines, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/mock_thumbnail_loader.js View 1 2 1 chunk +31 lines, -28 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
yawano
PTAL. Thank you!
5 years, 10 months ago (2015-02-05 08:47:42 UTC) #2
hirono
cool! lgtm! https://codereview.chromium.org/895093003/diff/40001/ui/file_manager/file_manager/foreground/js/list_thumbnail_loader.js File ui/file_manager/file_manager/foreground/js/list_thumbnail_loader.js (right): https://codereview.chromium.org/895093003/diff/40001/ui/file_manager/file_manager/foreground/js/list_thumbnail_loader.js#newcode275 ui/file_manager/file_manager/foreground/js/list_thumbnail_loader.js:275: * @return {!Promise} A promise which is ...
5 years, 10 months ago (2015-02-05 10:18:40 UTC) #3
yawano
Thank you! https://codereview.chromium.org/895093003/diff/40001/ui/file_manager/file_manager/foreground/js/list_thumbnail_loader.js File ui/file_manager/file_manager/foreground/js/list_thumbnail_loader.js (right): https://codereview.chromium.org/895093003/diff/40001/ui/file_manager/file_manager/foreground/js/list_thumbnail_loader.js#newcode275 ui/file_manager/file_manager/foreground/js/list_thumbnail_loader.js:275: * @return {!Promise} A promise which is ...
5 years, 10 months ago (2015-02-05 10:24:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/895093003/60001
5 years, 10 months ago (2015-02-05 10:25:23 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-02-05 13:55:24 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 13:57:59 UTC) #9
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/79796fe5810a16b29223f0f7f7bda9054012cf00
Cr-Commit-Position: refs/heads/master@{#314795}

Powered by Google App Engine
This is Rietveld 408576698