Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Unified Diff: ui/file_manager/file_manager/foreground/js/mock_thumbnail_loader.js

Issue 895093003: Change ListThumbnailLoader to use ThumbnailLoader.loadAsDataUrl. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix type annotation. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/file_manager/file_manager/foreground/js/list_thumbnail_loader_unittest.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/file_manager/file_manager/foreground/js/mock_thumbnail_loader.js
diff --git a/ui/file_manager/file_manager/foreground/js/mock_thumbnail_loader.js b/ui/file_manager/file_manager/foreground/js/mock_thumbnail_loader.js
index bf49a7ec9a6f63a32f5509a7c421053dd06755e0..d2b441476344bb776a0474cb59157960293caecb 100644
--- a/ui/file_manager/file_manager/foreground/js/mock_thumbnail_loader.js
+++ b/ui/file_manager/file_manager/foreground/js/mock_thumbnail_loader.js
@@ -14,43 +14,46 @@
*/
function MockThumbnailLoader(entry, opt_loaderType, opt_metadata, opt_mediaType,
opt_loadTargets, opt_priority) {
- this.testImageDataUrl_ = null;
+ this.entry_ = entry;
}
/**
- * @type {string} Data url of an image.
+ * Data url of test image.
+ * @private {string}
*/
-MockThumbnailLoader.testImageDataUrl_ = null;
+MockThumbnailLoader.testImageDataUrl = null;
/**
- * Set data url of an image which is returned for testing.
- *
- * @param {string} dataUrl Data url of an image.
+ * Width of test image.
+ * @private {number}
*/
-MockThumbnailLoader.setTestImageDataUrl = function(dataUrl) {
- MockThumbnailLoader.testImageDataUrl_ = dataUrl;
-};
+MockThumbnailLoader.testImageWidth = 0;
+
+/**
+ * Height of test image.
+ * @private {number}
+ */
+MockThumbnailLoader.testImageHeight = 0;
/**
- * Load an image. (This mock implementation does not attach an image to the
- * box).
+ * Error urls.
+ * @private {Array<string>}
+ */
+MockThumbnailLoader.errorUrls = [];
+
+/**
+ * Loads thumbnail as data url.
*
- * @param {Element} box Box.
- * @param {ThumbnailLoader.FillMode} fillMode Fill mode.
- * @param {ThumbnailLoader.OptimizationMode=} opt_optimizationMode Optimization.
- * @param {function(Image, Object)=} opt_onSuccess Success callback.
- * @param {function()=} opt_onError Error callback.
- * @param {function()=} opt_onGeneric Callback which is called when generic
- * image is used.
+ * @return {!Promise<{data:string, width:number, height:number}>} A promise
+ * which is resolved with data url.
*/
-MockThumbnailLoader.prototype.load = function(
- box, fillMode, opt_optimizationMode, opt_onSuccess, opt_onError,
- opt_onGeneric) {
- if (opt_onSuccess && MockThumbnailLoader.testImageDataUrl_) {
- var image = new Image();
- image.onload = function() {
- opt_onSuccess(image, null);
- };
- image.src = MockThumbnailLoader.testImageDataUrl_;
- }
+MockThumbnailLoader.prototype.loadAsDataUrl = function() {
+ if (MockThumbnailLoader.errorUrls.indexOf(this.entry_.toURL()) !== -1)
+ throw new Error('Failed to load thumbnail.');
+
+ return Promise.resolve({
+ data: MockThumbnailLoader.testImageDataUrl,
+ width: MockThumbnailLoader.testImageWidth,
+ height: MockThumbnailLoader.testImageHeight
+ });
};
« no previous file with comments | « ui/file_manager/file_manager/foreground/js/list_thumbnail_loader_unittest.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698