Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: runtime/observatory/lib/src/service/object.dart

Issue 895093002: Add getClassList RPC (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/class_table.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/lib/src/service/object.dart
diff --git a/runtime/observatory/lib/src/service/object.dart b/runtime/observatory/lib/src/service/object.dart
index 1d9d4017b9d091a960798008a05082e3196f36fe..ba937e2f21dd14b6e813d4e3ba1bd69e1b5fa836 100644
--- a/runtime/observatory/lib/src/service/object.dart
+++ b/runtime/observatory/lib/src/service/object.dart
@@ -835,14 +835,15 @@ class Isolate extends ServiceObjectOwner with Coverage {
/// Fetches and builds the class hierarchy for this isolate. Returns the
/// Object class object.
Future<Class> getClassHierarchy() {
- return get('classes').then(_loadClasses).then(_buildClassHierarchy);
+ return invokeRpc('getClassList', {}).then(
+ _loadClasses).then(_buildClassHierarchy);
turnidge 2015/02/03 17:39:29 Not sure how to best indent this... blah()
Cutch 2015/02/03 17:54:30 Done.
}
/// Given the class list, loads each class.
Future<List<Class>> _loadClasses(ServiceMap classList) {
assert(classList.type == 'ClassList');
var futureClasses = [];
- for (var cls in classList['members']) {
+ for (var cls in classList['classes']) {
// Skip over non-class classes.
if (cls is Class) {
futureClasses.add(cls.load());
« no previous file with comments | « no previous file | runtime/vm/class_table.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698