Add getClassList RPC

runtime/observatory/lib/src/service/object.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of service;
 
 /// A [ServiceObject] is an object known to the VM service and is tied
 /// to an owning [Isolate].
 abstract class ServiceObject extends Observable {
   static int LexicalSortName(ServiceObject o1, ServiceObject o2) {
@@ skipping 817 matching lines @@
     var sampleCount = profile['samples'];
     for (var codeRegion in codeRegions) {
       Code code = codeRegion['code'];
       code.updateProfileData(codeRegion, codeTable, sampleCount);
     }
   }
 
   /// Fetches and builds the class hierarchy for this isolate. Returns the
   /// Object class object.
   Future<Class> getClassHierarchy() {
-    return get('classes').then(_loadClasses).then(_buildClassHierarchy);
+    return invokeRpc('getClassList', {}).then(
+        _loadClasses).then(_buildClassHierarchy);

[turnidge, 2015/02/03 17:39:29]

Not sure how to best indent this...

   blah()
   .then(blah)
   .then(blah)

?

Or just leave it alone.  Your call.

[Cutch, 2015/02/03 17:54:30]

Done.

   }
 
   /// Given the class list, loads each class.
   Future<List<Class>> _loadClasses(ServiceMap classList) {
     assert(classList.type == 'ClassList');
     var futureClasses = [];
-    for (var cls in classList['members']) {
+    for (var cls in classList['classes']) {
       // Skip over non-class classes.
       if (cls is Class) {
         futureClasses.add(cls.load());
       }
     }
     return Future.wait(futureClasses);
   }
 
   /// Builds the class hierarchy and returns the Object class.
   Future<Class> _buildClassHierarchy(List<Class> classes) {
@@ skipping 2053 matching lines @@
     var v = list[i];
     if ((v is ObservableMap) && _isServiceMap(v)) {
       list[i] = owner.getFromMap(v);
     } else if (v is ObservableList) {
       _upgradeObservableList(v, owner);
     } else if (v is ObservableMap) {
       _upgradeObservableMap(v, owner);
     }
   }
 }