move_source_file.py: Update GN files in addition to GYP files

move_source_file.py: Update GN files in addition to GYP files

The change only handles files moved/renamed withing the same
BUILD.gn file. If files are moved beyond the same BUILD.gn file,
the affected BUILD.gn files should be fixed manually.

BUG=404616
TEST=1) rename files with git mv
     2) run tools/git/mass-rename.sh
     3) confirm that BUILD.gn is updated as expected

Committed: https://crrev.com/6decda6f18f847755f97b79e0fb69581d6431021
Cr-Commit-Position: refs/heads/master@{#314945}

[satorux1, 2015-02-03 07:12:37]

satorux@chromium.org changed reviewers:
+ derat@chromium.org

[satorux1, 2015-02-03 07:12:37]

joi is no longer active on chromium. picking up derat@ for no particular reason.
:)

[Daniel Erat, 2015-02-03 15:19:56]

thanks for doing this!

https://codereview.chromium.org/894973002/diff/1/tools/git/move_source_file.py
File tools/git/move_source_file.py (right):

https://codereview.chromium.org/894973002/diff/1/tools/git/move_source_file.p...
tools/git/move_source_file.py:120: ['*.gyp*', '*.gn'])
can this be BUILD.gn instead of *.gn? i think that all of our gn files are named
BUILD.gn. there are also .gni files, which i'm not familiar with, but none of
the ones that i looked at contained source file paths, so i think you probably
don't need to rewrite those.

[satorux1, 2015-02-04 05:13:18]

https://codereview.chromium.org/894973002/diff/1/tools/git/move_source_file.py
File tools/git/move_source_file.py (right):

https://codereview.chromium.org/894973002/diff/1/tools/git/move_source_file.p...
tools/git/move_source_file.py:120: ['*.gyp*', '*.gn'])
On 2015/02/03 15:19:56, Daniel Erat wrote:
> can this be BUILD.gn instead of *.gn? i think that all of our gn files are
named
> BUILD.gn. there are also .gni files, which i'm not familiar with, but none of
> the ones that i looked at contained source file paths, so i think you probably
> don't need to rewrite those.

Good point. It had to be */BUILD.gn for git grep to work as intended.

However, I tested it a bit more and found that this patch was not able to handle
a rename in chrome/browser/chromeos because paths in
chrome/browser/chromeos/BUILD.gn are only base names (ex. "device_uma.h") rather
than "PathMinusFirstComponent" (ex. 'browser/chromeos/xx_device_uma.h'). I
didn't see this problem as I was originally testing with files under
google_apis...

[satorux1, 2015-02-04 06:47:37]

The change became bigger than originally anticipated, but the new version can
handle relative paths more wisely. PTAL

[Daniel Erat, 2015-02-04 15:22:43]

lgtm

https://codereview.chromium.org/894973002/diff/20001/tools/git/move_source_fi...
File tools/git/move_source_file.py (right):

https://codereview.chromium.org/894973002/diff/20001/tools/git/move_source_fi...
tools/git/move_source_file.py:128: # For instance,
"chrome/browser/chromeos/device_uma.h.h" is listed as
nit: s/\.h\.h/.h/

https://codereview.chromium.org/894973002/diff/20001/tools/git/move_source_fi...
tools/git/move_source_file.py:142: '' -> ('', '')
nice examples!

[satorux1, 2015-02-06 01:23:27]

New patchsets have been uploaded after l-g-t-m from derat@chromium.org

[satorux1, 2015-02-06 01:23:41]

https://codereview.chromium.org/894973002/diff/20001/tools/git/move_source_fi...
File tools/git/move_source_file.py (right):

https://codereview.chromium.org/894973002/diff/20001/tools/git/move_source_fi...
tools/git/move_source_file.py:128: # For instance,
"chrome/browser/chromeos/device_uma.h.h" is listed as
On 2015/02/04 15:22:42, Daniel Erat wrote:
> nit: s/\.h\.h/.h/

Done.

[satorux1, 2015-02-06 01:23:49]

The CQ bit was checked by satorux@chromium.org

[commit-bot: I haz the power, 2015-02-06 01:24:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/894973002/40001

[commit-bot: I haz the power, 2015-02-06 02:07:10]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-02-06 02:08:24]

Patchset 3 (id:??) landed as
https://crrev.com/6decda6f18f847755f97b79e0fb69581d6431021
Cr-Commit-Position: refs/heads/master@{#314945}