move_source_file.py: Update GN files in addition to GYP files

tools/git/move_source_file.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Moves C++ files to a new location, updating any include paths that point
 to them, and re-ordering headers as needed.  If multiple source files are
 specified, the destination must be a directory.  Updates include guards in
 moved header files.  Assumes Chromium coding style.
 
@@ skipping 99 matching lines @@
   def PathMinusFirstComponent(path):
     """foo/bar/baz -> bar/baz"""
     parts = re.split(r"[/\\]", path, 1)
     if len(parts) == 2:
       return parts[1]
     else:
       return parts[0]
   mffr.MultiFileFindReplace(
       r'([\'"])%s([\'"])' % re.escape(PathMinusFirstComponent(from_path)),
       r'\1%s\2' % PathMinusFirstComponent(to_path),
-      ['*.gyp*'])
+      ['*.gyp*', '*.gn'])

[Daniel Erat, 2015/02/03 15:19:56]

can this be BUILD.gn instead of *.gn? i think that all of our gn files are named
BUILD.gn. there are also .gni files, which i'm not familiar with, but none of
the ones that i looked at contained source file paths, so i think you probably
don't need to rewrite those.

[satorux1, 2015/02/04 05:13:18]

Good point. It had to be */BUILD.gn for git grep to work as intended.

However, I tested it a bit more and found that this patch was not able to handle
a rename in chrome/browser/chromeos because paths in
chrome/browser/chromeos/BUILD.gn are only base names (ex. "device_uma.h") rather
than "PathMinusFirstComponent" (ex. 'browser/chromeos/xx_device_uma.h'). I
didn't see this problem as I was originally testing with files under
google_apis...

 
 
 def MakeIncludeGuardName(path_from_root):
   """Returns an include guard name given a path from root."""
   guard = path_from_root.replace('/', '_')
   guard = guard.replace('\\', '_')
   guard = guard.replace('.', '_')
   guard += '_'
   return guard.upper()
 
@@ skipping 58 matching lines @@
       continue
     to_path = MakeDestinationPath(from_path, orig_to_path)
     if not opts.already_moved:
       MoveFile(from_path, to_path)
     UpdatePostMove(from_path, to_path)
   return 0
 
 
 if __name__ == '__main__':
   sys.exit(main())