Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 894753006: Calls to the CallIC miss handler looked up the receiver incorrectly. (Closed)

Created:
5 years, 10 months ago by mvstanton
Modified:
5 years, 10 months ago
Reviewers:
ulan
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Calls to the CallIC miss handler looked up the receiver incorrectly. On platforms that don't push the return address on the stack at time of call, there was an error. R=ulan@chromium.org Committed: https://crrev.com/13b97b6214d8448c568d2e547e4a04c5fb468f5d Cr-Commit-Position: refs/heads/master@{#26439}

Patch Set 1 #

Patch Set 2 : REBASE. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/arm/code-stubs-arm.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mvstanton
Hi Ulan, PTAL, thx!
5 years, 10 months ago (2015-02-04 16:33:36 UTC) #1
ulan
lgtm
5 years, 10 months ago (2015-02-04 16:38:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/894753006/2
5 years, 10 months ago (2015-02-04 17:10:09 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:2)
5 years, 10 months ago (2015-02-04 17:46:05 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 17:46:22 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/13b97b6214d8448c568d2e547e4a04c5fb468f5d
Cr-Commit-Position: refs/heads/master@{#26439}

Powered by Google App Engine
This is Rietveld 408576698