Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(850)

Side by Side Diff: src/arm64/code-stubs-arm64.cc

Issue 894753006: Calls to the CallIC miss handler looked up the receiver incorrectly. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: REBASE. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM64 7 #if V8_TARGET_ARCH_ARM64
8 8
9 #include "src/bootstrapper.h" 9 #include "src/bootstrapper.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 3163 matching lines...) Expand 10 before | Expand all | Expand 10 after
3174 3174
3175 // Goto slow case if we do not have a function. 3175 // Goto slow case if we do not have a function.
3176 __ JumpIfNotObjectType(function, x10, type, JS_FUNCTION_TYPE, &slow); 3176 __ JumpIfNotObjectType(function, x10, type, JS_FUNCTION_TYPE, &slow);
3177 __ B(&have_js_function); 3177 __ B(&have_js_function);
3178 } 3178 }
3179 3179
3180 3180
3181 void CallICStub::GenerateMiss(MacroAssembler* masm) { 3181 void CallICStub::GenerateMiss(MacroAssembler* masm) {
3182 ASM_LOCATION("CallICStub[Miss]"); 3182 ASM_LOCATION("CallICStub[Miss]");
3183 3183
3184 // Get the receiver of the function from the stack; 1 ~ return address. 3184 // Get the receiver of the function from the stack.
3185 __ Peek(x4, (arg_count() + 1) * kPointerSize); 3185 __ Peek(x4, arg_count() * kPointerSize);
3186 3186
3187 { 3187 {
3188 FrameScope scope(masm, StackFrame::INTERNAL); 3188 FrameScope scope(masm, StackFrame::INTERNAL);
3189 3189
3190 // Push the receiver and the function and feedback info. 3190 // Push the receiver and the function and feedback info.
3191 __ Push(x4, x1, x2, x3); 3191 __ Push(x4, x1, x2, x3);
3192 3192
3193 // Call the entry. 3193 // Call the entry.
3194 IC::UtilityId id = GetICState() == DEFAULT ? IC::kCallIC_Miss 3194 IC::UtilityId id = GetICState() == DEFAULT ? IC::kCallIC_Miss
3195 : IC::kCallIC_Customization_Miss; 3195 : IC::kCallIC_Customization_Miss;
(...skipping 2228 matching lines...) Expand 10 before | Expand all | Expand 10 after
5424 kStackUnwindSpace, NULL, spill_offset, 5424 kStackUnwindSpace, NULL, spill_offset,
5425 MemOperand(fp, 6 * kPointerSize), NULL); 5425 MemOperand(fp, 6 * kPointerSize), NULL);
5426 } 5426 }
5427 5427
5428 5428
5429 #undef __ 5429 #undef __
5430 5430
5431 } } // namespace v8::internal 5431 } } // namespace v8::internal
5432 5432
5433 #endif // V8_TARGET_ARCH_ARM64 5433 #endif // V8_TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698