chrome/browser/password_manager/native_backend_gnome_x_unittest.cc - Issue 894583003: Rename PasswordForm::is_zero_click to PasswordForm::skip_next_zero_click.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/native_backend_gnome_x_unittest.cc

Issue 894583003: Rename PasswordForm::is_zero_click to PasswordForm::skip_next_zero_click. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix linux Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/native_backend_gnome_x.cc ('k') | chrome/browser/password_manager/native_backend_kwallet_x.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/native_backend_gnome_x_unittest.cc

diff --git a/chrome/browser/password_manager/native_backend_gnome_x_unittest.cc b/chrome/browser/password_manager/native_backend_gnome_x_unittest.cc

index 0f144b9ee26f663626049ef315c689c6e5d2196d..4ba35ff0586ef8010d32826c3820212919be4105 100644

--- a/chrome/browser/password_manager/native_backend_gnome_x_unittest.cc

+++ b/chrome/browser/password_manager/native_backend_gnome_x_unittest.cc

@@ -308,7 +308,7 @@ void CheckPasswordChanges(const PasswordStoreChangeList& expected_list,

EXPECT_EQ(expected.display_name, actual.display_name);

EXPECT_EQ(expected.avatar_url, actual.avatar_url);

EXPECT_EQ(expected.federation_url, actual.federation_url);

- EXPECT_EQ(expected.is_zero_click, actual.is_zero_click);

+ EXPECT_EQ(expected.skip_zero_click, actual.skip_zero_click);

}

@@ -356,7 +356,7 @@ class NativeBackendGnomeTest : public testing::Test {

form_google_.display_name = UTF8ToUTF16("Joe Schmoe");

form_google_.avatar_url = GURL("http://www.google.com/avatar");

form_google_.federation_url = GURL("http://www.google.com/federation_url");

- form_google_.is_zero_click = true;

+ form_google_.skip_zero_click = true;

form_facebook_.origin = GURL("http://www.facebook.com/");

form_facebook_.action = GURL("http://www.facebook.com/login");

@@ -371,7 +371,7 @@ class NativeBackendGnomeTest : public testing::Test {

form_facebook_.display_name = UTF8ToUTF16("Joe Schmoe");

form_facebook_.avatar_url = GURL("http://www.facebook.com/avatar");

form_facebook_.federation_url = GURL("http://www.facebook.com/federation");

- form_facebook_.is_zero_click = true;

+ form_facebook_.skip_zero_click = true;

form_isc_.origin = GURL("http://www.isc.org/");

form_isc_.action = GURL("http://www.isc.org/auth");

@@ -469,7 +469,7 @@ class NativeBackendGnomeTest : public testing::Test {

CheckStringAttribute(item, "display_name", UTF16ToUTF8(form.display_name));

CheckStringAttribute(item, "avatar_url", form.avatar_url.spec());

CheckStringAttribute(item, "federation_url", form.federation_url.spec());

- CheckUint32Attribute(item, "is_zero_click", form.is_zero_click);

+ CheckUint32Attribute(item, "skip_zero_click", form.skip_zero_click);

CheckStringAttribute(item, "application", app_string);

}