Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Side by Side Diff: chrome/browser/password_manager/native_backend_gnome_x_unittest.cc

Issue 894583003: Rename PasswordForm::is_zero_click to PasswordForm::skip_next_zero_click. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix linux Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stdarg.h> 5 #include <stdarg.h>
6 6
7 #include "base/basictypes.h" 7 #include "base/basictypes.h"
8 #include "base/prefs/pref_service.h" 8 #include "base/prefs/pref_service.h"
9 #include "base/strings/string_number_conversions.h" 9 #include "base/strings/string_number_conversions.h"
10 #include "base/strings/string_util.h" 10 #include "base/strings/string_util.h"
(...skipping 290 matching lines...) Expand 10 before | Expand all | Expand 10 after
301 // We don't check the date created. It varies due to bug in the 301 // We don't check the date created. It varies due to bug in the
302 // serialization. Integer seconds are saved instead of microseconds. 302 // serialization. Integer seconds are saved instead of microseconds.
303 EXPECT_EQ(expected.blacklisted_by_user, actual.blacklisted_by_user); 303 EXPECT_EQ(expected.blacklisted_by_user, actual.blacklisted_by_user);
304 EXPECT_EQ(expected.type, actual.type); 304 EXPECT_EQ(expected.type, actual.type);
305 EXPECT_EQ(expected.times_used, actual.times_used); 305 EXPECT_EQ(expected.times_used, actual.times_used);
306 EXPECT_EQ(expected.scheme, actual.scheme); 306 EXPECT_EQ(expected.scheme, actual.scheme);
307 EXPECT_EQ(expected.date_synced, actual.date_synced); 307 EXPECT_EQ(expected.date_synced, actual.date_synced);
308 EXPECT_EQ(expected.display_name, actual.display_name); 308 EXPECT_EQ(expected.display_name, actual.display_name);
309 EXPECT_EQ(expected.avatar_url, actual.avatar_url); 309 EXPECT_EQ(expected.avatar_url, actual.avatar_url);
310 EXPECT_EQ(expected.federation_url, actual.federation_url); 310 EXPECT_EQ(expected.federation_url, actual.federation_url);
311 EXPECT_EQ(expected.is_zero_click, actual.is_zero_click); 311 EXPECT_EQ(expected.skip_zero_click, actual.skip_zero_click);
312 } 312 }
313 } 313 }
314 314
315 void CheckPasswordChangesWithResult(const PasswordStoreChangeList* expected, 315 void CheckPasswordChangesWithResult(const PasswordStoreChangeList* expected,
316 const PasswordStoreChangeList* actual, 316 const PasswordStoreChangeList* actual,
317 bool result) { 317 bool result) {
318 EXPECT_TRUE(result); 318 EXPECT_TRUE(result);
319 CheckPasswordChanges(*expected, *actual); 319 CheckPasswordChanges(*expected, *actual);
320 } 320 }
321 321
(...skipping 27 matching lines...) Expand all
349 form_google_.password_element = UTF8ToUTF16("pass"); 349 form_google_.password_element = UTF8ToUTF16("pass");
350 form_google_.password_value = UTF8ToUTF16("seekrit"); 350 form_google_.password_value = UTF8ToUTF16("seekrit");
351 form_google_.submit_element = UTF8ToUTF16("submit"); 351 form_google_.submit_element = UTF8ToUTF16("submit");
352 form_google_.signon_realm = "http://www.google.com/"; 352 form_google_.signon_realm = "http://www.google.com/";
353 form_google_.type = PasswordForm::TYPE_GENERATED; 353 form_google_.type = PasswordForm::TYPE_GENERATED;
354 form_google_.date_created = base::Time::Now(); 354 form_google_.date_created = base::Time::Now();
355 form_google_.date_synced = base::Time::Now(); 355 form_google_.date_synced = base::Time::Now();
356 form_google_.display_name = UTF8ToUTF16("Joe Schmoe"); 356 form_google_.display_name = UTF8ToUTF16("Joe Schmoe");
357 form_google_.avatar_url = GURL("http://www.google.com/avatar"); 357 form_google_.avatar_url = GURL("http://www.google.com/avatar");
358 form_google_.federation_url = GURL("http://www.google.com/federation_url"); 358 form_google_.federation_url = GURL("http://www.google.com/federation_url");
359 form_google_.is_zero_click = true; 359 form_google_.skip_zero_click = true;
360 360
361 form_facebook_.origin = GURL("http://www.facebook.com/"); 361 form_facebook_.origin = GURL("http://www.facebook.com/");
362 form_facebook_.action = GURL("http://www.facebook.com/login"); 362 form_facebook_.action = GURL("http://www.facebook.com/login");
363 form_facebook_.username_element = UTF8ToUTF16("user"); 363 form_facebook_.username_element = UTF8ToUTF16("user");
364 form_facebook_.username_value = UTF8ToUTF16("a"); 364 form_facebook_.username_value = UTF8ToUTF16("a");
365 form_facebook_.password_element = UTF8ToUTF16("password"); 365 form_facebook_.password_element = UTF8ToUTF16("password");
366 form_facebook_.password_value = UTF8ToUTF16("b"); 366 form_facebook_.password_value = UTF8ToUTF16("b");
367 form_facebook_.submit_element = UTF8ToUTF16("submit"); 367 form_facebook_.submit_element = UTF8ToUTF16("submit");
368 form_facebook_.signon_realm = "http://www.facebook.com/"; 368 form_facebook_.signon_realm = "http://www.facebook.com/";
369 form_facebook_.date_created = base::Time::Now(); 369 form_facebook_.date_created = base::Time::Now();
370 form_facebook_.date_synced = base::Time::Now(); 370 form_facebook_.date_synced = base::Time::Now();
371 form_facebook_.display_name = UTF8ToUTF16("Joe Schmoe"); 371 form_facebook_.display_name = UTF8ToUTF16("Joe Schmoe");
372 form_facebook_.avatar_url = GURL("http://www.facebook.com/avatar"); 372 form_facebook_.avatar_url = GURL("http://www.facebook.com/avatar");
373 form_facebook_.federation_url = GURL("http://www.facebook.com/federation"); 373 form_facebook_.federation_url = GURL("http://www.facebook.com/federation");
374 form_facebook_.is_zero_click = true; 374 form_facebook_.skip_zero_click = true;
375 375
376 form_isc_.origin = GURL("http://www.isc.org/"); 376 form_isc_.origin = GURL("http://www.isc.org/");
377 form_isc_.action = GURL("http://www.isc.org/auth"); 377 form_isc_.action = GURL("http://www.isc.org/auth");
378 form_isc_.username_element = UTF8ToUTF16("id"); 378 form_isc_.username_element = UTF8ToUTF16("id");
379 form_isc_.username_value = UTF8ToUTF16("janedoe"); 379 form_isc_.username_value = UTF8ToUTF16("janedoe");
380 form_isc_.password_element = UTF8ToUTF16("passwd"); 380 form_isc_.password_element = UTF8ToUTF16("passwd");
381 form_isc_.password_value = UTF8ToUTF16("ihazabukkit"); 381 form_isc_.password_value = UTF8ToUTF16("ihazabukkit");
382 form_isc_.submit_element = UTF8ToUTF16("login"); 382 form_isc_.submit_element = UTF8ToUTF16("login");
383 form_isc_.signon_realm = "http://www.isc.org/"; 383 form_isc_.signon_realm = "http://www.isc.org/";
384 form_isc_.date_created = base::Time::Now(); 384 form_isc_.date_created = base::Time::Now();
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
462 // We don't check the date created. It varies. 462 // We don't check the date created. It varies.
463 CheckUint32Attribute(item, "blacklisted_by_user", form.blacklisted_by_user); 463 CheckUint32Attribute(item, "blacklisted_by_user", form.blacklisted_by_user);
464 CheckUint32Attribute(item, "type", form.type); 464 CheckUint32Attribute(item, "type", form.type);
465 CheckUint32Attribute(item, "times_used", form.times_used); 465 CheckUint32Attribute(item, "times_used", form.times_used);
466 CheckUint32Attribute(item, "scheme", form.scheme); 466 CheckUint32Attribute(item, "scheme", form.scheme);
467 CheckStringAttribute(item, "date_synced", base::Int64ToString( 467 CheckStringAttribute(item, "date_synced", base::Int64ToString(
468 form.date_synced.ToInternalValue())); 468 form.date_synced.ToInternalValue()));
469 CheckStringAttribute(item, "display_name", UTF16ToUTF8(form.display_name)); 469 CheckStringAttribute(item, "display_name", UTF16ToUTF8(form.display_name));
470 CheckStringAttribute(item, "avatar_url", form.avatar_url.spec()); 470 CheckStringAttribute(item, "avatar_url", form.avatar_url.spec());
471 CheckStringAttribute(item, "federation_url", form.federation_url.spec()); 471 CheckStringAttribute(item, "federation_url", form.federation_url.spec());
472 CheckUint32Attribute(item, "is_zero_click", form.is_zero_click); 472 CheckUint32Attribute(item, "skip_zero_click", form.skip_zero_click);
473 CheckStringAttribute(item, "application", app_string); 473 CheckStringAttribute(item, "application", app_string);
474 } 474 }
475 475
476 // Saves |credentials| and then gets logins matching |url| and |scheme|. 476 // Saves |credentials| and then gets logins matching |url| and |scheme|.
477 // Returns true when something is found, and in such case copies the result to 477 // Returns true when something is found, and in such case copies the result to
478 // |result| when |result| is not NULL. (Note that there can be max. 1 result, 478 // |result| when |result| is not NULL. (Note that there can be max. 1 result,
479 // derived from |credentials|.) 479 // derived from |credentials|.)
480 bool CheckCredentialAvailability(const PasswordForm& credentials, 480 bool CheckCredentialAvailability(const PasswordForm& credentials,
481 const GURL& url, 481 const GURL& url,
482 const PasswordForm::Scheme& scheme, 482 const PasswordForm::Scheme& scheme,
(...skipping 582 matching lines...) Expand 10 before | Expand all | Expand 10 after
1065 1065
1066 TEST_F(NativeBackendGnomeTest, RemoveLoginsCreatedBetween) { 1066 TEST_F(NativeBackendGnomeTest, RemoveLoginsCreatedBetween) {
1067 CheckRemoveLoginsBetween(CREATED); 1067 CheckRemoveLoginsBetween(CREATED);
1068 } 1068 }
1069 1069
1070 TEST_F(NativeBackendGnomeTest, RemoveLoginsSyncedBetween) { 1070 TEST_F(NativeBackendGnomeTest, RemoveLoginsSyncedBetween) {
1071 CheckRemoveLoginsBetween(SYNCED); 1071 CheckRemoveLoginsBetween(SYNCED);
1072 } 1072 }
1073 1073
1074 // TODO(mdm): add more basic tests here at some point. 1074 // TODO(mdm): add more basic tests here at some point.
OLDNEW
« no previous file with comments | « chrome/browser/password_manager/native_backend_gnome_x.cc ('k') | chrome/browser/password_manager/native_backend_kwallet_x.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698