components/autofill/core/common/password_form.h - Issue 894583003: Rename PasswordForm::is_zero_click to PasswordForm::skip_next_zero_click.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/common/password_form.h

Issue 894583003: Rename PasswordForm::is_zero_click to PasswordForm::skip_next_zero_click. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: +comment Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/password_store_mac_unittest.cc ('k') | components/autofill/core/common/password_form.cc » ('j') | components/password_manager/core/browser/login_database.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/common/password_form.h

diff --git a/components/autofill/core/common/password_form.h b/components/autofill/core/common/password_form.h

index be85cd3e21eccd3360ae5b959f0261cdd3575557..e2327bf596a6682460c800dfdc3e6fcaaadb627f 100644

--- a/components/autofill/core/common/password_form.h

+++ b/components/autofill/core/common/password_form.h

@@ -218,9 +218,10 @@ struct PasswordForm {

// The URL of identity provider used for federated login.

GURL federation_url;

- // If true, Chrome will sign the user in automatically using the credentials.

- // This field isn't synced deliberately.

- bool is_zero_click;

+ // If true, Chrome will not return this credential to a site in response to

+ // 'navigator.credentials.request()' without user interaction.

+ // Once user selects this credential the flag is reseted.

+ bool skip_next_zero_click;

Garrett Casto 2015/02/04 06:58:40 As someone that isn't particularly involved here,

vasilii 2015/02/04 12:44:02 Done.

// Returns true if this match was found using public suffix matching.

bool IsPublicSuffixMatch() const;