chrome/browser/password_manager/password_store_mac_unittest.cc - Issue 894583003: Rename PasswordForm::is_zero_click to PasswordForm::skip_next_zero_click.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/password_store_mac_unittest.cc

Issue 894583003: Rename PasswordForm::is_zero_click to PasswordForm::skip_next_zero_click. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: +comment Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/native_backend_libsecret_unittest.cc ('k') | components/autofill/core/common/password_form.h » ('j') | components/autofill/core/common/password_form.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/password_store_mac_unittest.cc

diff --git a/chrome/browser/password_manager/password_store_mac_unittest.cc b/chrome/browser/password_manager/password_store_mac_unittest.cc

index 29a3f90f6c8b93e0ad1f891d6ce2f87c928d97a8..ae44d7c4507c8aaf25432306c4d38a5bf72b5cf2 100644

--- a/chrome/browser/password_manager/password_store_mac_unittest.cc

+++ b/chrome/browser/password_manager/password_store_mac_unittest.cc

@@ -255,7 +255,7 @@ static PasswordForm* CreatePasswordFormFromData(

if (form_data.username_value) {

form->username_value = WideToUTF16(form_data.username_value);

form->display_name = form->username_value;

- form->is_zero_click = true;

+ form->skip_next_zero_click = true;

if (form_data.password_value)

form->password_value = WideToUTF16(form_data.password_value);

} else {

@@ -307,7 +307,7 @@ static void CheckFormsAgainstExpectations(

form->username_value) << test_label;

EXPECT_EQ(WideToUTF16(expectation->username_value),

form->display_name) << test_label;

- EXPECT_TRUE(form->is_zero_click) << test_label;

+ EXPECT_TRUE(form->skip_next_zero_click) << test_label;

EXPECT_EQ(WideToUTF16(expectation->password_value),

form->password_value) << test_label;

} else {