chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc - Issue 894583003: Rename PasswordForm::is_zero_click to PasswordForm::skip_next_zero_click.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc

Issue 894583003: Rename PasswordForm::is_zero_click to PasswordForm::skip_next_zero_click. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: +comment Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/native_backend_kwallet_x.cc ('k') | chrome/browser/password_manager/native_backend_libsecret.cc » ('j') | components/autofill/core/common/password_form.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc

diff --git a/chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc b/chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc

index 53de5bade8149f33a8d933ce03088ec87221e4b6..c226a5c4b58cfac54f92a1bd407cca17642f6c30 100644

--- a/chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc

+++ b/chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc

@@ -167,7 +167,7 @@ class NativeBackendKWalletTestBase : public testing::Test {

form_google_.display_name = UTF8ToUTF16("Joe Schmoe");

form_google_.avatar_url = GURL("http://www.google.com/avatar");

form_google_.federation_url = GURL("http://www.google.com/federation_url");

- form_google_.is_zero_click = true;

+ form_google_.skip_next_zero_click = true;

form_isc_.origin = GURL("http://www.isc.org/");

form_isc_.action = GURL("http://www.isc.org/auth");

@@ -216,7 +216,7 @@ void NativeBackendKWalletTestBase::CheckPasswordForm(

EXPECT_EQ(expected.display_name, actual.display_name);

EXPECT_EQ(expected.avatar_url, actual.avatar_url);

EXPECT_EQ(expected.federation_url, actual.federation_url);

- EXPECT_EQ(expected.is_zero_click, actual.is_zero_click);

+ EXPECT_EQ(expected.skip_next_zero_click, actual.skip_next_zero_click);

}

// static

@@ -996,7 +996,7 @@ void NativeBackendKWalletPickleTest::CheckVersion3Pickle() {

form.display_name.clear();

form.avatar_url = GURL();

form.federation_url = GURL();

- form.is_zero_click = false;

+ form.skip_next_zero_click = false;

CreateVersion3Pickle(form, &pickle);

ScopedVector<PasswordForm> form_list;