Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: content/renderer/render_view_impl.cc

Issue 894193003: ResizeSynchronously should resize the visible viewport as well. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed variable names Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/renderer/render_widget.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index 670dae090649e644a1386745db70326284f47cef..3be3eb3dc32babf3b16c29ae68776e847a6863ad 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -2014,13 +2014,13 @@ void RenderViewImpl::show(WebNavigationPolicy policy) {
DCHECK(opener_id_ != MSG_ROUTING_NONE);
- // NOTE: initial_pos_ may still have its default values at this point, but
+ // NOTE: initial_rect_ may still have its default values at this point, but
// that's okay. It'll be ignored if disposition is not NEW_POPUP, or the
// browser process will impose a default position otherwise.
Send(new ViewHostMsg_ShowView(opener_id_, routing_id_,
- NavigationPolicyToDisposition(policy), initial_pos_,
+ NavigationPolicyToDisposition(policy), initial_rect_,
opened_by_user_gesture_));
- SetPendingWindowRect(initial_pos_);
+ SetPendingWindowRect(initial_rect_);
}
void RenderViewImpl::runModal() {
@@ -4034,11 +4034,11 @@ void RenderViewImpl::SetDeviceColorProfileForTesting(
}
void RenderViewImpl::ForceResizeForTesting(const gfx::Size& new_size) {
- gfx::Rect new_position(rootWindowRect().x,
- rootWindowRect().y,
- new_size.width(),
- new_size.height());
- ResizeSynchronously(new_position, new_size);
+ gfx::Rect new_window_rect(rootWindowRect().x,
+ rootWindowRect().y,
+ new_size.width(),
+ new_size.height());
+ SetWindowRectSynchronously(new_window_rect);
}
void RenderViewImpl::UseSynchronousResizeModeForTesting(bool enable) {
« no previous file with comments | « no previous file | content/renderer/render_widget.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698