Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 894153003: Captive Portal Interstitial: Use SSID even if connection type isn't Wi-Fi. (Closed)

Created:
5 years, 10 months ago by meacer
Modified:
5 years, 10 months ago
Reviewers:
felt
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Captive Portal Interstitial: Use SSID even if connection type isn't Wi-Fi. |IsWiFiConnection| isn't accurate on some platforms. Whenever SSID is available, use it and ignore |IsWiFiConnection|. This CL also adds a delegate to |CaptivePortalBlockingPage| for better testing. BUG=451272 Committed: https://crrev.com/67f91dc7b23fca0bd5c78f179c76302d411e6f06 Cr-Commit-Position: refs/heads/master@{#314391}

Patch Set 1 #

Patch Set 2 : Remove Linux check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -94 lines) Patch
M chrome/browser/ssl/captive_portal_blocking_page.h View 1 4 chunks +13 lines, -12 lines 0 comments Download
M chrome/browser/ssl/captive_portal_blocking_page.cc View 1 3 chunks +66 lines, -74 lines 0 comments Download
M chrome/browser/ssl/captive_portal_blocking_page_browsertest.cc View 1 5 chunks +41 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
meacer
felt: Can you PTAL? Thanks.
5 years, 10 months ago (2015-02-03 01:05:04 UTC) #2
felt
Nice catch, and I like the use of the delegate. lgtm
5 years, 10 months ago (2015-02-03 08:01:49 UTC) #3
meacer
Thanks. I was going to land this after https://codereview.chromium.org/899573002/, but it actually works without the ...
5 years, 10 months ago (2015-02-03 19:07:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/894153003/20001
5 years, 10 months ago (2015-02-03 19:11:56 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-03 19:59:55 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 20:00:59 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/67f91dc7b23fca0bd5c78f179c76302d411e6f06
Cr-Commit-Position: refs/heads/master@{#314391}

Powered by Google App Engine
This is Rietveld 408576698