Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: chrome/browser/ssl/captive_portal_blocking_page.h

Issue 894153003: Captive Portal Interstitial: Use SSID even if connection type isn't Wi-Fi. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove Linux check Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ssl/captive_portal_blocking_page.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ssl/captive_portal_blocking_page.h
diff --git a/chrome/browser/ssl/captive_portal_blocking_page.h b/chrome/browser/ssl/captive_portal_blocking_page.h
index e5cdd8976790fc26af4452274899758d9c39a6f1..0b150cb6f3fb19683bd53b2721d10b8cb365488d 100644
--- a/chrome/browser/ssl/captive_portal_blocking_page.h
+++ b/chrome/browser/ssl/captive_portal_blocking_page.h
@@ -9,6 +9,7 @@
#include "base/callback.h"
#include "base/macros.h"
+#include "base/memory/scoped_ptr.h"
#include "chrome/browser/interstitials/security_interstitial_page.h"
#include "url/gurl.h"
@@ -28,6 +29,16 @@ class CaptivePortalBlockingPage : public SecurityInterstitialPage {
// Interstitial type, for testing.
static const void* kTypeForTesting;
+ class Delegate {
+ public:
+ virtual ~Delegate() {}
+
+ // Returns true if the connection is a Wi-Fi connection.
+ virtual bool IsWifiConnection() const = 0;
+ // Returns the SSID of the connected Wi-Fi network, if any.
+ virtual std::string GetWiFiSSID() const = 0;
+ };
+
CaptivePortalBlockingPage(content::WebContents* web_contents,
const GURL& request_url,
const GURL& login_url,
@@ -37,13 +48,7 @@ class CaptivePortalBlockingPage : public SecurityInterstitialPage {
// SecurityInterstitialPage method:
const void* GetTypeForTesting() const override;
- void SetWiFiConnectionForTesting(bool is_wifi_connection) {
- is_wifi_connection_ = is_wifi_connection;
- }
-
- void SetWiFiSSIDForTesting(const std::string& wifi_ssid) {
- wifi_ssid_ = wifi_ssid;
- }
+ void SetDelegateForTesting(Delegate* delegate) { delegate_.reset(delegate); }
protected:
// SecurityInterstitialPage methods:
@@ -57,11 +62,7 @@ class CaptivePortalBlockingPage : public SecurityInterstitialPage {
private:
// URL of the login page, opened when the user clicks the "Connect" button.
GURL login_url_;
- // True if on a Wi-Fi connection.
- bool is_wifi_connection_;
- // SSID of the connected network if the connection is a Wi-Fi connection.
- std::string wifi_ssid_;
-
+ scoped_ptr<Delegate> delegate_;
base::Callback<void(bool)> callback_;
DISALLOW_COPY_AND_ASSIGN(CaptivePortalBlockingPage);
« no previous file with comments | « no previous file | chrome/browser/ssl/captive_portal_blocking_page.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698