Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 894093003: Delete zombie udp_socket_unittest. (Closed)

Created:
5 years, 10 months ago by ppi
Modified:
5 years, 10 months ago
Reviewers:
jamesr
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete zombie udp_socket_unittest. This file was deprecated by corresponding apptests and was deleted in https://codereview.chromium.org/722943004 . It was accidentally ressurected when moving the network service source-of-truth to Chromium - we carried over modifications and new files, but didn't carry over deletions of whole files. BUG=450356 Committed: https://crrev.com/f74b2a3e0fe3c7b1bbc7ddba186d758147bb298b Cr-Commit-Position: refs/heads/master@{#314601}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -458 lines) Patch
D mojo/services/network/udp_socket_unittest.cc View 1 chunk +0 lines, -458 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
ppi
Hi James, ptal.
5 years, 10 months ago (2015-02-04 16:41:38 UTC) #3
jamesr
lgtm
5 years, 10 months ago (2015-02-04 18:29:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/894093003/20001
5 years, 10 months ago (2015-02-04 18:33:02 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 10 months ago (2015-02-04 19:09:48 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 19:12:30 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f74b2a3e0fe3c7b1bbc7ddba186d758147bb298b
Cr-Commit-Position: refs/heads/master@{#314601}

Powered by Google App Engine
This is Rietveld 408576698