Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 722943004: Remove network_service_unittests target, now that its replacement network_service_apptests is runni… (Closed)

Created:
6 years, 1 month ago by yzshen1
Modified:
6 years ago
Reviewers:
msw
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove network_service_unittests target, now that its replacement network_service_apptests is running on bots. BUG=None TEST=None R=msw@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/caedda9c03b329441c48b667b371a1e19bf9637c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -483 lines) Patch
M mojo/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/services/network/BUILD.gn View 1 chunk +0 lines, -23 lines 0 comments Download
D mojo/services/network/udp_socket_unittest.cc View 1 chunk +0 lines, -458 lines 0 comments Download
M mojo/tools/data/unittests View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
yzshen1
Hi, Michael. Would you please take a look? Thanks!
6 years, 1 month ago (2014-11-21 17:36:35 UTC) #2
msw
Sorry for the delayed response, this looks pretty good, but let's hold off until my ...
6 years, 1 month ago (2014-11-22 18:30:16 UTC) #3
yzshen1
On 2014/11/22 18:30:16, msw wrote: > Sorry for the delayed response, this looks pretty good, ...
6 years ago (2014-11-24 22:11:39 UTC) #4
msw
lgtm!
6 years ago (2014-11-24 22:13:22 UTC) #5
yzshen1
6 years ago (2014-11-24 22:19:42 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
caedda9c03b329441c48b667b371a1e19bf9637c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698