Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 893843003: Add RedirectInfo as a redirect parameter to ResourceThrottles. (Closed)

Created:
5 years, 10 months ago by mmenke
Modified:
5 years, 10 months ago
CC:
chromium-reviews, asanka, davidben+watch_chromium.org, cbentzel+watch_chromium.org, gavinp+prer_chromium.org, benjhayden+dwatch_chromium.org, jam, tburkard+watch_chromium.org, pam+watch_chromium.org, jkarlin+watch_chromium.org, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add RedirectInfo as a redirect parameter to ResourceThrottles. This lets this CL to also remove URLRequest::GetMethodForRedirect(). BUG=455744 Committed: https://crrev.com/44629d64ec3c0e2c95a4cf08ea70b5dde89257fc Cr-Commit-Position: refs/heads/master@{#315761}

Patch Set 1 #

Patch Set 2 : Fix stuff #

Patch Set 3 : Merge #

Patch Set 4 : Fix webview #

Total comments: 3

Patch Set 5 : Response to David's comment #

Total comments: 2

Patch Set 6 : Document ResourceThrottle #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -76 lines) Patch
M android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc View 1 2 3 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/component_updater/component_updater_resource_throttle.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/download/download_resource_throttle.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/download/download_resource_throttle.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/prerender/prerender_resource_throttle.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/prerender/prerender_resource_throttle.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/prerender/prerender_tracker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/safe_browsing_resource_throttle.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/safe_browsing_resource_throttle.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_resource_throttle.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/supervised_user/supervised_user_resource_throttle.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M components/navigation_interception/intercept_navigation_resource_throttle.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/navigation_interception/intercept_navigation_resource_throttle.cc View 2 chunks +4 lines, -13 lines 0 comments Download
M components/navigation_interception/intercept_navigation_resource_throttle_unittest.cc View 1 2 3 4 3 chunks +12 lines, -5 lines 0 comments Download
M content/browser/loader/throttling_resource_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/resource_throttle.h View 1 2 3 4 5 2 chunks +16 lines, -1 line 0 comments Download
M net/url_request/url_request.h View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M net/url_request/url_request.cc View 1 2 1 chunk +0 lines, -20 lines 0 comments Download
M net/url_request/url_request_job.cc View 2 chunks +25 lines, -6 lines 0 comments Download

Messages

Total messages: 29 (8 generated)
mmenke
This one is addressing a TODO of yours, so a bit less random sending it ...
5 years, 10 months ago (2015-02-05 20:17:16 UTC) #4
davidben
lgtm! https://codereview.chromium.org/893843003/diff/100001/components/navigation_interception/intercept_navigation_resource_throttle.cc File components/navigation_interception/intercept_navigation_resource_throttle.cc (left): https://codereview.chromium.org/893843003/diff/100001/components/navigation_interception/intercept_navigation_resource_throttle.cc#oldcode101 components/navigation_interception/intercept_navigation_resource_throttle.cc:101: request_->method(), headers->response_code()); All that work to remove this ...
5 years, 10 months ago (2015-02-05 20:44:06 UTC) #5
mmenke
https://codereview.chromium.org/893843003/diff/100001/components/navigation_interception/intercept_navigation_resource_throttle_unittest.cc File components/navigation_interception/intercept_navigation_resource_throttle_unittest.cc (right): https://codereview.chromium.org/893843003/diff/100001/components/navigation_interception/intercept_navigation_resource_throttle_unittest.cc#newcode164 components/navigation_interception/intercept_navigation_resource_throttle_unittest.cc:164: redirect_info.new_method = new_method; On 2015/02/05 20:44:06, David Benjamin wrote: ...
5 years, 10 months ago (2015-02-05 21:20:54 UTC) #7
mmenke
5 years, 10 months ago (2015-02-05 21:23:00 UTC) #9
mmenke
[+mnaganov]: Please review components/navigation_interception. I consider the rest of this to be TBR-worthy. I'm just ...
5 years, 10 months ago (2015-02-05 21:27:39 UTC) #11
James Hawkins
Can you clarify why you aren't waiting for my review?
5 years, 10 months ago (2015-02-05 21:28:36 UTC) #12
mmenke
On 2015/02/05 21:28:36, James Hawkins wrote: > Can you clarify why you aren't waiting for ...
5 years, 10 months ago (2015-02-05 21:30:21 UTC) #13
James Hawkins
On 2015/02/05 21:30:21, mmenke wrote: > On 2015/02/05 21:28:36, James Hawkins wrote: > > Can ...
5 years, 10 months ago (2015-02-05 21:30:50 UTC) #14
sgurun-gerrit only
On 2015/02/05 21:30:50, James Hawkins wrote: > On 2015/02/05 21:30:21, mmenke wrote: > > On ...
5 years, 10 months ago (2015-02-05 21:31:14 UTC) #15
James Hawkins
lgtm https://codereview.chromium.org/893843003/diff/120001/content/public/browser/resource_throttle.h File content/public/browser/resource_throttle.h (right): https://codereview.chromium.org/893843003/diff/120001/content/public/browser/resource_throttle.h#newcode31 content/public/browser/resource_throttle.h:31: virtual void WillRedirectRequest(const net::RedirectInfo& redirect_info, Consider documenting the ...
5 years, 10 months ago (2015-02-05 21:34:31 UTC) #16
sgurun-gerrit only
On 2015/02/05 21:34:31, James Hawkins wrote: > lgtm > > https://codereview.chromium.org/893843003/diff/120001/content/public/browser/resource_throttle.h > File content/public/browser/resource_throttle.h (right): ...
5 years, 10 months ago (2015-02-05 22:02:35 UTC) #18
mmenke
https://codereview.chromium.org/893843003/diff/120001/content/public/browser/resource_throttle.h File content/public/browser/resource_throttle.h (right): https://codereview.chromium.org/893843003/diff/120001/content/public/browser/resource_throttle.h#newcode31 content/public/browser/resource_throttle.h:31: virtual void WillRedirectRequest(const net::RedirectInfo& redirect_info, On 2015/02/05 21:34:31, James ...
5 years, 10 months ago (2015-02-05 22:02:47 UTC) #19
mmenke
mnaganov: Ping!
5 years, 10 months ago (2015-02-10 18:43:54 UTC) #20
mnaganov (inactive)
Apologies, this somehow fell off from my sight. android_webview/ lgtm
5 years, 10 months ago (2015-02-10 21:43:58 UTC) #21
sgurun-gerrit only
On 2015/02/10 21:43:58, mnaganov (cr) wrote: > Apologies, this somehow fell off from my sight. ...
5 years, 10 months ago (2015-02-10 21:47:45 UTC) #22
mmenke
On 2015/02/10 21:47:45, sgurun wrote: > On 2015/02/10 21:43:58, mnaganov (cr) wrote: > > Apologies, ...
5 years, 10 months ago (2015-02-10 21:49:15 UTC) #23
mnaganov (inactive)
On 2015/02/10 21:49:15, mmenke wrote: > On 2015/02/10 21:47:45, sgurun wrote: > > On 2015/02/10 ...
5 years, 10 months ago (2015-02-11 09:58:02 UTC) #24
mmenke
On 2015/02/11 09:58:02, mnaganov (cr) wrote: > On 2015/02/10 21:49:15, mmenke wrote: > > On ...
5 years, 10 months ago (2015-02-11 14:28:44 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/893843003/140001
5 years, 10 months ago (2015-02-11 14:29:25 UTC) #27
commit-bot: I haz the power
Committed patchset #6 (id:140001)
5 years, 10 months ago (2015-02-11 15:16:01 UTC) #28
commit-bot: I haz the power
5 years, 10 months ago (2015-02-11 15:16:48 UTC) #29
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/44629d64ec3c0e2c95a4cf08ea70b5dde89257fc
Cr-Commit-Position: refs/heads/master@{#315761}

Powered by Google App Engine
This is Rietveld 408576698