Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Side by Side Diff: content/public/browser/resource_throttle.h

Issue 893843003: Add RedirectInfo as a redirect parameter to ResourceThrottles. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Response to David's comment Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/browser/loader/throttling_resource_handler.cc ('k') | net/url_request/url_request.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_PUBLIC_BROWSER_RESOURCE_THROTTLE_H_ 5 #ifndef CONTENT_PUBLIC_BROWSER_RESOURCE_THROTTLE_H_
6 #define CONTENT_PUBLIC_BROWSER_RESOURCE_THROTTLE_H_ 6 #define CONTENT_PUBLIC_BROWSER_RESOURCE_THROTTLE_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 class GURL; 10 class GURL;
11 11
12 namespace net {
13 struct RedirectInfo;
14 }
15
12 namespace content { 16 namespace content {
13 17
14 class ResourceController; 18 class ResourceController;
15 19
16 // A ResourceThrottle gets notified at various points during the process of 20 // A ResourceThrottle gets notified at various points during the process of
17 // loading a resource. At each stage, it has the opportunity to defer the 21 // loading a resource. At each stage, it has the opportunity to defer the
18 // resource load. The ResourceController interface may be used to resume a 22 // resource load. The ResourceController interface may be used to resume a
19 // deferred resource load, or it may be used to cancel a resource load at any 23 // deferred resource load, or it may be used to cancel a resource load at any
20 // time. 24 // time.
21 class ResourceThrottle { 25 class ResourceThrottle {
22 public: 26 public:
23 virtual ~ResourceThrottle() {} 27 virtual ~ResourceThrottle() {}
24 28
25 virtual void WillStartRequest(bool* defer) {} 29 virtual void WillStartRequest(bool* defer) {}
26 virtual void WillStartUsingNetwork(bool* defer) {} 30 virtual void WillStartUsingNetwork(bool* defer) {}
27 virtual void WillRedirectRequest(const GURL& new_url, bool* defer) {} 31 virtual void WillRedirectRequest(const net::RedirectInfo& redirect_info,
James Hawkins 2015/02/05 21:34:31 Consider documenting the redirect_info param.
mmenke 2015/02/05 22:02:47 Done! Good idea, went ahead and documented the ot
32 bool* defer) {}
28 virtual void WillProcessResponse(bool* defer) {} 33 virtual void WillProcessResponse(bool* defer) {}
29 34
30 // Returns the name of the throttle, as a UTF-8 C-string, for logging 35 // Returns the name of the throttle, as a UTF-8 C-string, for logging
31 // purposes. nullptr is not allowed. Caller does *not* take ownership of the 36 // purposes. nullptr is not allowed. Caller does *not* take ownership of the
32 // returned string. 37 // returned string.
33 virtual const char* GetNameForLogging() const = 0; 38 virtual const char* GetNameForLogging() const = 0;
34 39
35 void set_controller_for_testing(ResourceController* c) { 40 void set_controller_for_testing(ResourceController* c) {
36 controller_ = c; 41 controller_ = c;
37 } 42 }
38 43
39 protected: 44 protected:
40 ResourceThrottle() : controller_(nullptr) {} 45 ResourceThrottle() : controller_(nullptr) {}
41 ResourceController* controller() { return controller_; } 46 ResourceController* controller() { return controller_; }
42 47
43 private: 48 private:
44 friend class ThrottlingResourceHandler; 49 friend class ThrottlingResourceHandler;
45 void set_controller(ResourceController* c) { controller_ = c; } 50 void set_controller(ResourceController* c) { controller_ = c; }
46 51
47 ResourceController* controller_; 52 ResourceController* controller_;
48 }; 53 };
49 54
50 } // namespace content 55 } // namespace content
51 56
52 #endif // CONTENT_PUBLIC_BROWSER_RESOURCE_THROTTLE_H_ 57 #endif // CONTENT_PUBLIC_BROWSER_RESOURCE_THROTTLE_H_
OLDNEW
« no previous file with comments | « content/browser/loader/throttling_resource_handler.cc ('k') | net/url_request/url_request.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698