Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Issue 893783002: Revert of Gather the ServiceWorker client information in the browser process. (Closed)

Created:
5 years, 10 months ago by horo
Modified:
5 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, horo+watch_chromium.org, jam, jsbell+serviceworker_chromium.org, kinuko+serviceworker, michaeln, mkwst+moarreviews-renderer_chromium.org, Mike West, nasko, nhiroki, serviceworker-reviews, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@rfh_getvisibilitystate
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Gather the ServiceWorker client information in the browser process. (patchset #8 id:140001 of https://codereview.chromium.org/871013003/) Reason for revert: This patch is causing http/tests/serviceworker/clients-getall.html to fail on the mac bots: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Fserviceworker%2Fclients-getall.html&showLargeExpectations=true Original issue's description: > Gather the ServiceWorker client information in the browser process. > > This is also adding some logic about empty and invalid > ServiceWorkerClientInfo. > > BUG=450634 > > Committed: https://crrev.com/5d6924925a291a7cf394a685772251c83a63f99f > Cr-Commit-Position: refs/heads/master@{#313982} TBR=jochen@chromium.org,michaeln@chromium.org,tsepez@chromium.org,mlamouri@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=450634 Committed: https://crrev.com/c313f474933df016da94fbeb0892152a0d8e5b0f Cr-Commit-Position: refs/heads/master@{#314052}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -168 lines) Patch
M content/browser/service_worker/service_worker_provider_host.h View 2 chunks +2 lines, -4 lines 0 comments Download
M content/browser/service_worker/service_worker_provider_host.cc View 3 chunks +4 lines, -32 lines 0 comments Download
M content/browser/service_worker/service_worker_version.h View 5 chunks +10 lines, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_version.cc View 8 chunks +44 lines, -23 lines 0 comments Download
M content/child/service_worker/service_worker_dispatcher.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/child/service_worker/service_worker_dispatcher.cc View 2 chunks +26 lines, -0 lines 0 comments Download
D content/common/service_worker/service_worker_client_info.h View 1 chunk +0 lines, -42 lines 0 comments Download
D content/common/service_worker/service_worker_client_info.cc View 1 chunk +0 lines, -42 lines 0 comments Download
M content/common/service_worker/service_worker_messages.h View 3 chunks +16 lines, -1 line 0 comments Download
M content/common/service_worker/service_worker_types.h View 2 chunks +8 lines, -1 line 0 comments Download
M content/content_common.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/service_worker/service_worker_script_context.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/service_worker/service_worker_script_context.cc View 2 chunks +8 lines, -17 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
horo
Created Revert of Gather the ServiceWorker client information in the browser process.
5 years, 10 months ago (2015-01-31 10:02:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/893783002/1
5 years, 10 months ago (2015-01-31 10:03:54 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-31 10:05:56 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-01-31 10:06:43 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c313f474933df016da94fbeb0892152a0d8e5b0f
Cr-Commit-Position: refs/heads/master@{#314052}

Powered by Google App Engine
This is Rietveld 408576698