Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1628)

Unified Diff: content/renderer/service_worker/service_worker_script_context.cc

Issue 893783002: Revert of Gather the ServiceWorker client information in the browser process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@rfh_getvisibilitystate
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/service_worker/service_worker_script_context.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/service_worker/service_worker_script_context.cc
diff --git a/content/renderer/service_worker/service_worker_script_context.cc b/content/renderer/service_worker/service_worker_script_context.cc
index 013f027c650f56ce988bef5a82d457b9f4d16fa1..9d8acc4467084af6fcc0801e0911e91bf054dc0f 100644
--- a/content/renderer/service_worker/service_worker_script_context.cc
+++ b/content/renderer/service_worker/service_worker_script_context.cc
@@ -70,21 +70,6 @@
blink::WebURLRequest::FrameType GetBlinkFrameType(
RequestContextFrameType frame_type) {
return static_cast<blink::WebURLRequest::FrameType>(frame_type);
-}
-
-blink::WebServiceWorkerClientInfo
-ToWebServiceWorkerClientInfo(const ServiceWorkerClientInfo& client_info) {
- DCHECK(client_info.IsValid());
-
- blink::WebServiceWorkerClientInfo web_client_info;
-
- web_client_info.clientID = client_info.client_id;
- web_client_info.pageVisibilityState = client_info.page_visibility_state;
- web_client_info.isFocused = client_info.is_focused;
- web_client_info.url = client_info.url;
- web_client_info.frameType = GetBlinkFrameType(client_info.frame_type);
-
- return web_client_info;
}
} // namespace
@@ -435,8 +420,14 @@
new blink::WebServiceWorkerClientsInfo);
blink::WebVector<blink::WebServiceWorkerClientInfo> convertedClients(
clients.size());
- for (size_t i = 0; i < clients.size(); ++i)
- convertedClients[i] = ToWebServiceWorkerClientInfo(clients[i]);
+ for (size_t i = 0; i < clients.size(); ++i) {
+ convertedClients[i].clientID = clients[i].client_id;
+ convertedClients[i].pageVisibilityState = clients[i].page_visibility_state;
+ convertedClients[i].isFocused = clients[i].is_focused;
+ convertedClients[i].url = clients[i].url;
+ convertedClients[i].frameType =
+ static_cast<blink::WebURLRequest::FrameType>(clients[i].frame_type);
+ }
info->clients.swap(convertedClients);
callbacks->onSuccess(info.release());
pending_clients_callbacks_.Remove(request_id);
« no previous file with comments | « content/renderer/service_worker/service_worker_script_context.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698