Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1411)

Unified Diff: Source/web/TopControls.h

Issue 893683003: Implement top controls show/hide functionality for main thread scrolling (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix hiding at the page bottom issue Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/TopControls.h
diff --git a/Source/web/TopControls.h b/Source/web/TopControls.h
new file mode 100644
index 0000000000000000000000000000000000000000..d233b3c8ac134d2e723e7e0f1056000a30de91d1
--- /dev/null
+++ b/Source/web/TopControls.h
@@ -0,0 +1,107 @@
+/*
+ * Copyright (C) 2015 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+ * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ * DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY
+ * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+ * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+ * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
+ * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
+ * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#ifndef TopControls_h
+#define TopControls_h
+
+#include "public/web/WebTopControlsState.h"
+
+namespace blink {
+class PlatformGestureEvent;
+class WebViewImpl;
+
+// This class encapsulate data and logic required to scroll top controls.
+// Top controls' self-animation is still handled by compositor and kicks in when
+// scroll is complete (i.e, ScrollEnd, or FlingEnd).
+class TopControls {
+public:
+ explicit TopControls(WebViewImpl*);
+
+ // The amount that the viewport was shrunk by to accommodate the top
+ // controls.
+ float layoutHeight();
+ // The amount that top controls are currently shown.
+ float contentOffset();
+
+ void setHeight(float);
+ void setShrinkViewport(bool);
+
+ float shownRatio() {return m_shownRatio;};
aelias_OOO_until_Jul13 2015/02/13 02:03:17 Should be const, have spaces around the braces, an
majidvp 2015/02/18 21:03:57 Done.
+ void setShownRatio(float);
+ void updateShownRatio(float delta);
aelias_OOO_until_Jul13 2015/02/13 02:03:17 I think this alternate way of setting it is more c
majidvp 2015/02/18 21:03:56 Done.
+
+ void updateState(
aelias_OOO_until_Jul13 2015/02/13 02:03:17 Let's just make this updateConstraints() since the
majidvp 2015/02/18 21:03:57 Done.
+ WebTopControlsState constraints,
+ WebTopControlsState current,
+ bool animate);
+
+ // Handles gesture event and returns true if event was consumed.
+ // |remainingDeltaY| will be the amount of vertical scroll that was not consumed.
+ bool handleGestureEvent(const PlatformGestureEvent&, float* remainingDeltaY);
+
+private:
+ void scrollBegin();
+ // Scrolls top controls vertically if possible and returns the remaining scroll
+ // amount.
+ float scrollBy(float scrollDelta);
+ void resetBaseline();
+
+ WebViewImpl* m_webView;
+
+ // The top controls height regardless of whether it is visible or not.
+ // |layoutHeight()| give your the amount that viewport is shrunk to
+ // accommodate top controls .
+ float m_height;
+
+ // The top controls shown amount (normalized from 0 to 1) since the last
+ // compositor commit. This value is updated from two sources:
+ // (1) compositor (impl) thread at the beginning of frame if it has
+ // scrolled top controls since last commit.
+ // (2) blink (main) thread updates this value if it scrolls top controls
+ // when responding to gesture scroll events.
+ // This value is reflected in web layer tree and is synced with compositor
+ // during the commit.
+ float m_shownRatio;
+
+ // Content offset when last re-baseline occurred.
+ float m_baselineContentOffset;
+
+ // Accumulated scroll delta since last re-baseline.
+ float m_accumulatedScrollDelta;
+
+ // If this is true, then the embedder shrunk the WebView size by the top
+ // controls height.
+ bool m_shrinkViewport;
+
+ // Constraints on the top controls state
+ WebTopControlsState m_permittedState;
+
+ // It true, then a pinch is in progress which causes top controls to ignore
+ // any scroll updates.
+ bool m_pinchGestureActive;
+};
+} // namespace blink
+
+#endif // TopControls_h

Powered by Google App Engine
This is Rietveld 408576698